uniform finalizer #153
Merged
uniform finalizer #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #153 +/- ##
=======================================
Coverage 89.25% 89.25%
=======================================
Files 13 13
Lines 1563 1563
=======================================
Hits 1395 1395
Misses 111 111
Partials 57 57 Continue to review full report at Codecov.
|
vgunapati
approved these changes
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #151
This modifies the way we set/remove finalizers in order to move to a uniform finalizer for all provisioners without breaking compatibility
SetFinalizer will add the new finalizer "finalizer.instancegroups.keikoproj.io" (which does not mention provisioner)
Finalize will remove ALL finalizers - given this is an owned resource that should be OK.
Basic tests