Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BDD syntax for Conditions #148

Merged
merged 2 commits into from
Jul 13, 2020

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented Jul 13, 2020

conditions syntax was always checking for true instead of actual condition declared in syntax

  • BDD passing

@eytan-avisror eytan-avisror requested review from a team as code owners July 13, 2020 16:47
@codecov
Copy link

codecov bot commented Jul 13, 2020

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   89.22%   89.22%           
=======================================
  Files          13       13           
  Lines        1559     1559           
=======================================
  Hits         1391     1391           
  Misses        111      111           
  Partials       57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f807563...d956194. Read the comment docs.

@eytan-avisror eytan-avisror merged commit ebba4c2 into keikoproj:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants