-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suspend processes #132
Suspend processes #132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
==========================================
- Coverage 88.93% 88.49% -0.44%
==========================================
Files 10 10
Lines 1193 1217 +24
==========================================
+ Hits 1061 1077 +16
- Misses 91 95 +4
- Partials 41 45 +4
Continue to review full report at Codecov.
|
Thanks for the PR and contribution @SaiVishwas |
…ance-manager into suspendProcesses
Thanks for the comments you addressed @SaiVishwas .. looks great! |
Hi @eytan-avisror ,
code block. Thank you |
Thanks @SaiVishwas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @SaiVishwas 🥇
15 scenarios (15 passed) |
PR #132 was missing the generated deepcopy changes.
Fixes #119
Assumption: In the desired/target state, only the processes mentioned in the input yaml need to be suspended on the ASG
Scenarios tested:
During Create
During Update
@eytan-avisror please review and let me know if you would like me to improve anything.
Thank you