Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS SDK Caching #127

Merged
merged 9 commits into from
May 29, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 28, 2020

Fixes #87

This adds caching for AWS calls

  • BDD test

  • Total calls: 1432

  • Cache Hits: 1137

  • Cache Misses: 295 (~20%)

  • Throttled: 0

  • Scale test (20 EKS IGs CREATE/DELETE)

  • Total calls: 1953

  • Cache Hits: 1071

  • Cache Misses: 882 (45%)

  • Throttled: 0

@eytan-avisror eytan-avisror requested a review from a team as a code owner May 28, 2020 20:07
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #127 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   88.77%   88.79%   +0.01%     
==========================================
  Files          10       10              
  Lines        1167     1169       +2     
==========================================
+ Hits         1036     1038       +2     
  Misses         91       91              
  Partials       40       40              
Impacted Files Coverage Δ
controllers/provisioners/eks/delete.go 95.45% <100.00%> (+0.06%) ⬆️
controllers/provisioners/eks/helpers.go 86.40% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5232733...d399f11. Read the comment docs.

Copy link

@gaganapplatix gaganapplatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eytan-avisror eytan-avisror merged commit 3feff0f into keikoproj:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provisioner Caching and throttling retries
3 participants