Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS API Optimization - IAM #126

Merged
merged 7 commits into from
May 28, 2020

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 28, 2020

Fixes #112

This optimizes the IAM calls we make by only trying to attach managed policies if they are not attached.

  • BDD test

@eytan-avisror eytan-avisror requested a review from a team as a code owner May 28, 2020 16:53
@codecov
Copy link

codecov bot commented May 28, 2020

Codecov Report

Merging #126 into master will increase coverage by 0.17%.
The diff coverage is 90.56%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   88.60%   88.77%   +0.17%     
==========================================
  Files          10       10              
  Lines        1123     1167      +44     
==========================================
+ Hits          995     1036      +41     
  Misses         91       91              
- Partials       37       40       +3     
Impacted Files Coverage Δ
controllers/provisioners/eks/helpers.go 86.36% <50.00%> (+0.41%) ⬆️
controllers/provisioners/eks/cloud.go 89.11% <81.81%> (-0.60%) ⬇️
controllers/provisioners/eks/update.go 97.41% <93.33%> (-0.61%) ⬇️
controllers/provisioners/eks/create.go 95.12% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a6d0fb...39e64fc. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 5232733 into keikoproj:master May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize AWS API calls
2 participants