Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS API Optimization - Update #124

Merged
merged 3 commits into from
May 27, 2020

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 27, 2020

Ref #112

This refactors the update flow to remove redundant API calls

  • BDD Passing

@eytan-avisror eytan-avisror requested a review from a team as a code owner May 27, 2020 03:25
@codecov
Copy link

codecov bot commented May 27, 2020

Codecov Report

Merging #124 into master will increase coverage by 1.00%.
The diff coverage is 90.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   87.59%   88.60%   +1.00%     
==========================================
  Files          10       10              
  Lines        1072     1123      +51     
==========================================
+ Hits          939      995      +56     
+ Misses         96       91       -5     
  Partials       37       37              
Impacted Files Coverage Δ
controllers/provisioners/eks/helpers.go 85.94% <71.42%> (+2.99%) ⬆️
controllers/provisioners/eks/cloud.go 89.70% <75.00%> (-0.92%) ⬇️
controllers/provisioners/eks/update.go 98.01% <94.82%> (-0.74%) ⬇️
controllers/provisioners/eks/upgrade.go 94.80% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 358dcb4...84c77d1. Read the comment docs.

@eytan-avisror eytan-avisror merged commit 6a6d0fb into keikoproj:master May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants