Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Publishing #110

Merged
merged 6 commits into from
May 19, 2020
Merged

Event Publishing #110

merged 6 commits into from
May 19, 2020

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 17, 2020

Fixes #100

Adds basic event publishing

  • BDD

@eytan-avisror eytan-avisror requested a review from a team as a code owner May 17, 2020 02:10
Eytan Avisror added 2 commits May 16, 2020 19:30
@codecov
Copy link

codecov bot commented May 17, 2020

Codecov Report

Merging #110 into master will decrease coverage by 0.09%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   87.02%   86.93%   -0.10%     
==========================================
  Files          10       10              
  Lines         979      995      +16     
==========================================
+ Hits          852      865      +13     
- Misses         91       94       +3     
  Partials       36       36              
Impacted Files Coverage Δ
controllers/provisioners/eks/helpers.go 79.13% <60.00%> (-0.43%) ⬇️
controllers/provisioners/eks/upgrade.go 94.73% <66.66%> (-1.16%) ⬇️
controllers/provisioners/eks/cloud.go 91.15% <100.00%> (+0.49%) ⬆️
controllers/provisioners/eks/create.go 100.00% <100.00%> (ø)
controllers/provisioners/eks/delete.go 96.92% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d794ad...065d481. Read the comment docs.

Copy link
Contributor

@vgunapati vgunapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@eytan-avisror eytan-avisror merged commit 90a8845 into keikoproj:master May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event publishing
2 participants