Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throttling Retries #106

Merged
merged 11 commits into from
May 16, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 15, 2020

Contributes to #87

This configures throttling retries, adds logging, and addresses some minor bugs.

  • BDD tests
  • Scale/load test (10 IGs created/deleted in parallel)

@eytan-avisror eytan-avisror requested a review from a team as a code owner May 15, 2020 17:40
@codecov
Copy link

codecov bot commented May 15, 2020

Codecov Report

Merging #106 into master will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #106      +/-   ##
==========================================
- Coverage   87.08%   87.06%   -0.02%     
==========================================
  Files          10       10              
  Lines         983      982       -1     
==========================================
- Hits          856      855       -1     
  Misses         91       91              
  Partials       36       36              
Impacted Files Coverage Δ
controllers/provisioners/eks/cloud.go 90.65% <66.66%> (-0.09%) ⬇️
controllers/provisioners/eks/update.go 93.86% <83.33%> (+0.03%) ⬆️
controllers/provisioners/eks/create.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63e0767...9c52067. Read the comment docs.

@eytan-avisror eytan-avisror changed the title Sdk caching Throttling Retries May 16, 2020
@eytan-avisror
Copy link
Collaborator Author

Will address caching in a different PR, we need throttling retries sooner

@eytan-avisror eytan-avisror merged commit 71e192f into keikoproj:master May 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants