Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap improvements #102

Merged
merged 6 commits into from
May 13, 2020
Merged

Conversation

eytan-avisror
Copy link
Collaborator

@eytan-avisror eytan-avisror commented May 13, 2020

Fixes #101

  • add locking around bootstrap, and call bootstrap on updates before we wait for nodes

  • make sure not to remove auth role if it's shared between instancegroups

  • BDD test

add locking around bootstrap, and call bootstrap on updates before we wait for nodes
@eytan-avisror eytan-avisror requested a review from a team as a code owner May 13, 2020 05:11
@eytan-avisror eytan-avisror requested a review from vgunapati May 13, 2020 05:11
@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #102 into master will decrease coverage by 0.22%.
The diff coverage is 82.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   87.31%   87.09%   -0.23%     
==========================================
  Files          10       10              
  Lines         954      984      +30     
==========================================
+ Hits          833      857      +24     
- Misses         88       91       +3     
- Partials       33       36       +3     
Impacted Files Coverage Δ
controllers/provisioners/eks/delete.go 96.87% <0.00%> (-3.13%) ⬇️
controllers/provisioners/eks/eks.go 64.86% <ø> (ø)
controllers/provisioners/eks/update.go 93.86% <33.33%> (-1.14%) ⬇️
controllers/provisioners/eks/helpers.go 79.55% <90.90%> (+1.23%) ⬆️
controllers/provisioners/eks/create.go 100.00% <100.00%> (ø)
controllers/provisioners/eks/upgrade.go 96.05% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4456c9...43ad288. Read the comment docs.

Copy link
Contributor

@vgunapati vgunapati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@eytan-avisror eytan-avisror merged commit 2eac28d into keikoproj:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bootstrapping issues
3 participants