[catalyst#166] Fix Unexpected Moodle Internal errors/warnings in CI

keevan · Jan 19, 2022 · 96de03d · 96de03d
1 parent 8228927
commit 96de03d
Show file tree

Hide file tree

Showing 37 changed files with 0 additions and 68 deletions.
diff --git a/classes/event_processor.php b/classes/event_processor.php
@@ -27,8 +27,6 @@
 use tool_trigger\helper\processor_helper;
 use tool_trigger\task\process_workflows;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Process trigger system events.
  *

diff --git a/classes/helper/datafield_manager.php b/classes/helper/datafield_manager.php
@@ -25,8 +25,6 @@
 
 namespace tool_trigger\helper;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * A lookup step that takes a user's ID and adds standard data about the
  * user.

diff --git a/classes/helper/processor_helper.php b/classes/helper/processor_helper.php
@@ -25,8 +25,6 @@
 
 namespace tool_trigger\helper;
 
-defined('MOODLE_INTERNAL') || die();
-
 trait processor_helper {
 
     /**

diff --git a/classes/json/json_export.php b/classes/json/json_export.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger\json;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Process trigger system events.
  *

diff --git a/classes/learn_process.php b/classes/learn_process.php
@@ -23,7 +23,6 @@
  */
 
 namespace tool_trigger;
-defined('MOODLE_INTERNAL') || die();
 /**
  * Process learnt events.
  *

diff --git a/classes/output/manageworkflows/renderer.php b/classes/output/manageworkflows/renderer.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger\output\manageworkflows;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renderer class for manage rules page.
  *

diff --git a/classes/privacy/provider.php b/classes/privacy/provider.php
@@ -24,8 +24,6 @@
  */
 namespace tool_trigger\privacy;
 
-defined('MOODLE_INTERNAL') || die();
-
 use core_privacy\local\metadata\collection;
 use core_privacy\local\request\contextlist;
 use core_privacy\local\request\approved_contextlist;

diff --git a/classes/steps/actions/base_action_step.php b/classes/steps/actions/base_action_step.php
@@ -29,8 +29,6 @@
 
 use tool_trigger\steps\base\base_step;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Base action step class.
  *

diff --git a/classes/steps/actions/email_action_step.php b/classes/steps/actions/email_action_step.php
@@ -25,8 +25,6 @@
 
 namespace tool_trigger\steps\actions;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * email action step class.
  *

diff --git a/classes/steps/actions/http_post_action_step.php b/classes/steps/actions/http_post_action_step.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger\steps\actions;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * HTTP Post action step class.
  *

diff --git a/classes/steps/actions/logdump_action_step.php b/classes/steps/actions/logdump_action_step.php
@@ -16,8 +16,6 @@
 
 namespace tool_trigger\steps\actions;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Action step that just does a var_dump to the logs.
  *

diff --git a/classes/steps/actions/role_assign_action_step.php b/classes/steps/actions/role_assign_action_step.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger\steps\actions;
 
-defined('MOODLE_INTERNAL') || die;
-
 class role_assign_action_step extends base_action_step {
 
     use \tool_trigger\helper\datafield_manager;

diff --git a/classes/steps/actions/role_unassign_action_step.php b/classes/steps/actions/role_unassign_action_step.php
@@ -25,8 +25,6 @@
 
 namespace tool_trigger\steps\actions;
 
-defined('MOODLE_INTERNAL') || die;
-
 class role_unassign_action_step extends base_action_step {
 
     use \tool_trigger\helper\datafield_manager;

diff --git a/classes/steps/actions/roles_unassign_action_step.php b/classes/steps/actions/roles_unassign_action_step.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger\steps\actions;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * HTTP Post action step class.
  *

diff --git a/classes/steps/base/base_step.php b/classes/steps/base/base_step.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger\steps\base;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Base step class.
  *

diff --git a/classes/steps/debounce/debounce_step.php b/classes/steps/debounce/debounce_step.php
@@ -31,8 +31,6 @@
 use xmldb_table;
 use xmldb_field;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Debounce step class.
  *

diff --git a/classes/steps/filters/base_filter_step.php b/classes/steps/filters/base_filter_step.php
@@ -29,8 +29,6 @@
 
 use tool_trigger\steps\base\base_step;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Base filter step class.
  *

diff --git a/classes/steps/filters/fail_filter_step.php b/classes/steps/filters/fail_filter_step.php
@@ -27,8 +27,6 @@
 
 namespace tool_trigger\steps\filters;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Fail filter step class.
  *

diff --git a/classes/steps/filters/numcompare_filter_step.php b/classes/steps/filters/numcompare_filter_step.php
@@ -27,8 +27,6 @@
 
 namespace tool_trigger\steps\filters;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Base filter step class.
  *

diff --git a/classes/steps/filters/stringcompare_filter_step.php b/classes/steps/filters/stringcompare_filter_step.php
@@ -27,8 +27,6 @@
 
 namespace tool_trigger\steps\filters;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Base filter step class.
  *

diff --git a/classes/steps/lookups/base_lookup_step.php b/classes/steps/lookups/base_lookup_step.php
@@ -30,8 +30,6 @@
 
 use tool_trigger\steps\base\base_step;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Base lookup step class.
  *

diff --git a/classes/steps/lookups/cohort_lookup_step.php b/classes/steps/lookups/cohort_lookup_step.php
@@ -16,7 +16,6 @@
 
 namespace tool_trigger\steps\lookups;
 
-defined('MOODLE_INTERNAL') || die;
 /**
  * A lookup step that takes a user's ID and returns a string of
  * all the cohorts that the user is currently assigned to

diff --git a/classes/steps/lookups/course_cat_lookup_step.php b/classes/steps/lookups/course_cat_lookup_step.php
@@ -16,8 +16,6 @@
 
 namespace tool_trigger\steps\lookups;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * A lookup step that takes a category ID and adds all data about the category.
  *

diff --git a/classes/steps/lookups/course_lookup_step.php b/classes/steps/lookups/course_lookup_step.php
@@ -16,8 +16,6 @@
 
 namespace tool_trigger\steps\lookups;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * A lookup step that takes a course's ID and adds standard data about the
  * course.

diff --git a/classes/steps/lookups/roles_lookup_step.php b/classes/steps/lookups/roles_lookup_step.php
@@ -16,8 +16,6 @@
 
 namespace tool_trigger\steps\lookups;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * A lookup step that takes a user's ID and adds roles of the user.
  *

diff --git a/classes/task/cleanup.php b/classes/task/cleanup.php
@@ -25,7 +25,6 @@
 
 namespace tool_trigger\task;
 
-defined('MOODLE_INTERNAL') || die();
 /**
  * Task to cleanup old queue.
  */

diff --git a/classes/task/cleanup_history.php b/classes/task/cleanup_history.php
@@ -25,7 +25,6 @@
 
 namespace tool_trigger\task;
 
-defined('MOODLE_INTERNAL') || die();
 /**
  * Task to cleanup old queue.
  */

diff --git a/classes/task/learn.php b/classes/task/learn.php
@@ -24,7 +24,6 @@
 
 namespace tool_trigger\task;
 
-defined('MOODLE_INTERNAL') || die();
 /**
  * Task to learn from processed events.
  */

diff --git a/classes/task/process_workflows.php b/classes/task/process_workflows.php
@@ -26,7 +26,6 @@
 
 use tool_trigger\helper\processor_helper;
 
-defined('MOODLE_INTERNAL') || die();
 /**
  * Simple task to rocess queued workflows.
  */

diff --git a/classes/task/update_trigger_helper_task.php b/classes/task/update_trigger_helper_task.php
@@ -25,8 +25,6 @@
 
 namespace tool_trigger\task;
 
-defined('MOODLE_INTERNAL') || die();
-
 
 /**
  * Helper task to offload upgrade processing

diff --git a/classes/workflow.php b/classes/workflow.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Worklfow class.
  *

diff --git a/classes/workflow_manager.php b/classes/workflow_manager.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Workflow manager class.
  *

diff --git a/classes/workflow_process.php b/classes/workflow_process.php
@@ -24,8 +24,6 @@
 
 namespace tool_trigger;
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Process workflow form.
  *

diff --git a/db/install.php b/db/install.php
@@ -23,8 +23,6 @@
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Add events fields from fixture file to database.
  */

diff --git a/db/upgrade.php b/db/upgrade.php
@@ -23,8 +23,6 @@
  * @license     http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 /**
  * Upgrade the plugin.
  *

diff --git a/lib.php b/lib.php
@@ -25,8 +25,6 @@
 use tool_trigger\steps\base\base_form;
 use tool_trigger\import_form;
 
-defined('MOODLE_INTERNAL') || die;
-
 /**
  * Renders the top part of the "new workflow step" modal form. (The part with
  * the "Step type" and "Step" menus.

diff --git a/tests/privacy_test.php b/tests/privacy_test.php
@@ -23,8 +23,6 @@
  * @license    http://www.gnu.org/copyleft/gpl.html GNU GPL v3 or later
  */
 
-defined('MOODLE_INTERNAL') || die();
-
 use \tool_trigger\privacy\provider;
 use \core_privacy\local\request\approved_contextlist;
 use \core_privacy\local\request\approved_userlist;
-Original file line number
+Diff line change
@@ Expand Up / @@ -25,8 +25,6 @@ @@
     namespace tool_trigger\helper;
-    defined('MOODLE_INTERNAL') || die;
     /**
      * A lookup step that takes a user's ID and adds standard data about the
      * user.
@@ Expand Down @@