This repository has been archived by the owner on Aug 7, 2019. It is now read-only.
Change header check constant to hex #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keepkeyjon
reviewed
Jan 15, 2019
Co-Authored-By: majorhayes <[email protected]>
keepkeyjon
reviewed
Jan 15, 2019
src/webUSBDevice.ts
Outdated
| @@ -77,10 +77,10 @@ export default class WebUSBDevice extends Device { | |||
| protected async read (): Promise<ByteBuffer> { | |||
| let first = await this.readChunk() | |||
|
|
|||
| // FIXME: assert that buffer starts with: [ 0x3f, 0x23, 0x23 ] | |||
| const valid = first.getUint32(0) === 1059267328 | |||
| // Check that buffer starts with: [ 0x3f, 0x23, 0x23, 0x00 ] | |||
There was a problem hiding this comment.
Suggested change
| // Check that buffer starts with: [ 0x3f, 0x23, 0x23, 0x00 ] | |
| // Check that buffer starts with: [ 0x3f, 0x23, 0x23 ] |
majorhayes
force-pushed
the
header-constant
branch
from
62b9fe0 to
df93f5e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changes the USB packet header constant change to be hex and remove the
FIXMEfrom the comment.