This repository has been archived by the owner on Aug 7, 2019. It is now read-only.
Fix errors caused by overlapping reads #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spiceboi
reviewed
Jan 15, 2019
| for (let i = 0; i < devicesToInitialize.length; i++) { | ||
| const usbDevice = devicesToInitialize[i] | ||
|
|
||
| const devicesToInitialize = devices || (await window.navigator.usb.getDevices()) |
ryankeepkey
approved these changes
Jan 15, 2019
* manager: Don't add devices that are already managed * webUsbDevice: Simplify loop to join packets
majorhayes
force-pushed
the
overlapping-reads
branch
from
d403a67 to
1bf3a52
Compare
keepkeyjon
reviewed
Jan 15, 2019
| for (let k = 0; k < first.byteLength; k++) { | ||
| buffer[k] = first.getUint8(k) | ||
| } | ||
| const valid = first.getUint32(0) === 1059267328 |
There was a problem hiding this comment.
Mind writing this constant it hex? I think that'll clarify what it's for.
There was a problem hiding this comment.
Just saw this after the merge (you didn't do Request Changes). There is a comment directly above this, but I can update the comment and the constant.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Since
transferInis asynchronous, it's possible to have multiple async loops (seewebUsbDevice.read()) to calltransferIn, causing some packets to end up in the wrong read loop.This manifests by a look expecting the first packet to have a header with a
messageLength, but since the packet it receives is not really a first packet, but the middle of some other read, the read length is incorrect and causes an error when attempting to create a massively large array.Resolution
Use
p-queueto add an async queue with a concurrency of 1 to only allow one message and response to the device at a time.Extra
This PR also simplifies some code around reading message length and concatenating packets.