Skip to content
This repository has been archived by the owner on Aug 7, 2019. It is now read-only.

refactor removeAll to use remove #26

Merged
merged 1 commit into from
Feb 5, 2019
Merged

refactor removeAll to use remove #26

merged 1 commit into from
Feb 5, 2019

Conversation

ryankeepkey
Copy link

  • Added try/catch around remove to avoid error from clearSession when device does not exist.
  • refactored removeAll to call this.remove (DRY)

KeepKeyBrett
KeepKeyBrett reviewed Feb 4, 2019
View reviewed changes
src/keepkeyManager.ts Outdated Show resolved Hide resolved
keepkeyjon
keepkeyjon reviewed Feb 4, 2019
View reviewed changes
src/keepkeyManager.ts Outdated Show resolved Hide resolved
KeepKeyBrett
KeepKeyBrett approved these changes Feb 4, 2019
View reviewed changes
src/keepkeyManager.ts Outdated Show resolved Hide resolved
@spiceboi spiceboi merged commit 6a5eb1c into master Feb 5, 2019
@spiceboi spiceboi deleted the keepkey-remove branch February 5, 2019 22:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@keepkeyjon keepkeyjon keepkeyjon left review comments

@KeepKeyBrett KeepKeyBrett KeepKeyBrett approved these changes

@spiceboi spiceboi spiceboi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryankeepkey @keepkeyjon @spiceboi @KeepKeyBrett