-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for keyboard shortcuts #3215
Conversation
- Fixes keepassxreboot#3175 - Added a reference in README.md to KEYBINDS.md Signed-off-by: sohamg <[email protected]>
- Fixes keepassxreboot#3175 - Added a reference in README.md to KEYBINDS.md Signed-off-by: sohamg <[email protected]>
Thanks for the overview! |
@PF93mc8y7erq92qTmTjJBysALa The only solution I can think of for that is to make it a PR requirement; @droidmonkey should I edit the pull request template file for this? I could look into automating, but I think thats for another PR. |
Seems a relevant one is already listed:
I think you are right - automating it (even just automating a test for it) could be another merge request. Thanks again! |
My pleasure :D
…On Tue, Jun 4, 2019, 8:22 PM PF93mc8y7erq92qTmTjJBysALa < ***@***.***> wrote:
PR Requirement
Seems a relevant one is already listed:
✅ My change requires a change to the documentation, and I have updated it
accordingly.
And that might be sufficient.
I think you are right - automating it (even just automating a test for it)
could be another merge request.
Thanks again!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#3215?email_source=notifications&email_token=ABWJLTY32XZFDGBFMDCJ3XLPYZ6RNA5CNFSM4HSGYAC2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW42NQI#issuecomment-498706113>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABWJLT6SKHP5ZM7NSR7AYPTPYZ6RNANCNFSM4HSGYACQ>
.
|
I wouldn't bother automating it. |
Type of change
Description and Context
Testing strategy
No code changes
Checklist:
-DWITH_ASAN=ON
. [REQUIRED]