Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make URL in Notes clickable #3511

Closed
gyli opened this issue Sep 5, 2019 · 2 comments · Fixed by #3596
Closed

Make URL in Notes clickable #3511

gyli opened this issue Sep 5, 2019 · 2 comments · Fixed by #3596

Comments

@gyli
Copy link

gyli commented Sep 5, 2019

Summary

A feature in KeePass I used to use a lot is that I can click the URL in Notes and it would open the link in browser.

Desired Behavior

Parse the URL in Notes, make it openable

Possible Solution

Context

Sometimes I would like to store links in Notes if I have to store multiple URLs and this feature allows me to open the link quickly.

@droidmonkey
Copy link
Member

Related to #1057

Chris-Johnston added a commit to Chris-Johnston/keepassxc that referenced this issue Oct 2, 2019
This change adds support for hyperlinks in the notes field of the
EntryPreviewWidget. This is done by enabling the
`openExternalLinks` property of `QLabel`, and modifying the
value of the content of this field so that links are wrapped
with `<a>` tags.

Links are assumed to use the format: `protocol://path`, since
assumptions cannot/shoudn't be made about the specific format of
a link. The text of the label uses the modified notes value.
droidmonkey pushed a commit to Chris-Johnston/keepassxc that referenced this issue Oct 5, 2019
This change adds support for hyperlinks in the notes field of the EntryPreviewWidget. This is done by enabling the `openExternalLinks` property of `QLabel`, and modifying the value of the content of this field so that links are wrapped
with `<a>` tags.

Links are assumed to use the format: `protocol://path`, since assumptions cannot/shoudn't be made about the specific format of a link. The text of the label uses the modified notes value.
droidmonkey pushed a commit that referenced this issue Oct 5, 2019
This change adds support for hyperlinks in the notes field of the EntryPreviewWidget. This is done by enabling the `openExternalLinks` property of `QLabel`, and modifying the value of the content of this field so that links are wrapped
with `<a>` tags.

Links are assumed to use the format: `protocol://path`, since assumptions cannot/shoudn't be made about the specific format of a link. The text of the label uses the modified notes value.
scoroi pushed a commit to scoroi/keepassxc that referenced this issue Nov 10, 2019
This change adds support for hyperlinks in the notes field of the EntryPreviewWidget. This is done by enabling the `openExternalLinks` property of `QLabel`, and modifying the value of the content of this field so that links are wrapped
with `<a>` tags.

Links are assumed to use the format: `protocol://path`, since assumptions cannot/shoudn't be made about the specific format of a link. The text of the label uses the modified notes value.
@Anubis-105

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants