-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automated rKP3R and ibEUR reward distribution #4
Open
wei3erHase
wants to merge
8
commits into
keep3r-network:master
Choose a base branch
from
defi-wonderland:dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: added hardhat boilerplate * chore: run linter * fix: rm legacy code * feat: added vyper compiler * feat: added github workflows * chore: revert linter * fix: solhint ignore
* chore: added hardhat boilerplate * chore: run linter * fix: rm legacy code * feat: added vyper compiler * feat: added github workflows * fix: linter error * feat: adding basic test structure * fix: typings bug * feat: added tests scaffolding * fix: revert linter * fix: run prettier
* feat: added reward distribution e2e test * chore: retrieved latest GaugeProxy version from etherscan * fix: e2e test importing current contracts * chore: gaugeProxyV2 * chore: revert unnecessary changes * fix: run linter
* refactor: separated interfaces * feat: added draw functionality * feat: added keeper functionality * style: renaming
* feat: added keep3r job scaffolding * feat: added interface to gaugeProxy * fix: natpsec bug * test: added job to e2e * test: added utils unit tests * fix: run linter * feat: added job unit test * feat: added coverage * feat: fixes and comments in PR * fix: linter * fix: rm overrides in job
* feat: added unit test to GaugeProxy distribution * feat: added deployment script * feat: added delegate script * fix: linter * fix: missing await * fix: weird bug * feat: added natspec * fix: added eth-sdk to postinstall * chore: returned contracts to original location * fix: ignoring eth-sdk abis * feat: added governance in constructor * fix: linter * feat: added inheritdoc for natpsec * fix: remove delgate deployment script * feat: improved tests * fix: linter * fix: typo * feat: improved unit test
0xGorilla
approved these changes
May 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
wei3erHase
changed the title
feat: automated rKP3R reward distribution
feat: automated rKP3R and ibEUR reward distribution
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed Forex Reward Distribution Job
GaugeProxy contract extracted from https://etherscan.io/address/0x81a8CAb6bb568fC94bCa70C9AdbFCF05592dEd7b
GaugeProxyV2 Changelog
keeper
distribute()
fromgov
tokeeper
forceDistribute()
allowed forgov
gov
parameter in constructorRewardDistributionJob
Has 3 functions to be upkept, each has a
timeout
work()
: distributes rKP3R to gauges, callsibController.profit()
andibBurner.update_snx()
exchange()
: callsibBurner.exchanger()
distribute()
: callsibBurner.distribute()
Registry
Keep3r Governance:
0x0d5dc686d0a2abbfdafdfb4d0533e886517d4e83
GaugeProxyV2:
0xEdA0b82211Bb7e6E7F0415713580ce91A3C41767
RewardDistributionJob:
TBD
Gauge Proxy Deployment
0x0d5dc686d0a2abbfdafdfb4d0533e886517d4e83
asgov
)Initialization
Keep3rV1Proxy.addRecipient( GaugeProxyV2.address, WEEKLY_AMOUNT_OF_KP3R )
GaugeProxyV2.addGauge( _pool, _gauge )
reward_distributor
in Curve for the corresponding gaugesforceDistribute()
, initializing thedraw
mechanism on Keep3rV1Proxy, next distribution will be possible a week after execution timestampUpkeep
0x0d5dc686d0a2abbfdafdfb4d0533e886517d4e83
asgov
)Keep3rV2.addJob(RewardDistributionJob)
Keep3rV2.acceptJobOwnership( RewardDistributionJob )
keeper
addressGaugeProxyV2.setKeeper(RewardDistributionJob)