Fix the TBTC token ownership update in deployment scripts for Goerli #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit tests cover the path of the VendingMachine upgrade to TBTCVault. We transfer the ownership of TBTC token to the VendingMachine for Hardhat network used for unit tests to enable this path. For all other environments (e.g. local dev, Goerli), we want the TBTCVault to be the owner of TBTC token. This simulates the final 1.0 version mainnet state.
pdyraga
force-pushed
the
tbtc-token-owner
branch
from
6253f2c
to
ea9759e
Compare
pdyraga
requested review from
michalinacienciala,
lukasz-zimnoch and
r-czajkowski
michalinacienciala
approved these changes
Jan 20, 2023
lukasz-zimnoch
approved these changes
Jan 20, 2023
r-czajkowski
added a commit
that referenced
this pull request
Jan 24, 2023
We want the TBTCVault to be the owner of the TBTC token and we do it in earlier deployment step. The script `94_*` was a workaround and now it's unnecessary. See #488.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests cover the path of the VendingMachine upgrade to TBTCVault. We transfer the ownership of TBTC token to the VendingMachine for Hardhat network used for unit tests to enable this path. For all other environments (e.g. local dev, Goerli), we want the TBTCVault to be the owner of TBTC token. This simulates the final 1.0 version mainnet state.