Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Temp fix for the problem with failing jobs - move cache instead of copying #822

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

michalinacienciala
Copy link
Contributor

We've seen a number of workflows failing with No space left on device
error (e.g.
https://github.com/keep-network/keep-ecdsa/actions/runs/924123923).
The problem was a combination of a big cache size and significant memory
allocation after building Docker image.
According to moby/buildkit#1850:
"At the moment caches are copied over the existing cache so it keeps
growing".
As a temporary fix (until issue gets fixed by GH), we introduce a step
that moves the cache (similarily to how it's described in
moby/buildkit#1896).

The solution may not keep us from failures forever, as we still may
hit the problems with the full memory if the size of the Docker image
or cache increases (see this FD discussion:
https://www.flowdock.com/app/cardforcoin/tech/threads/Clml1_lI4HYRKrr3N_vcSInDn6A).

…pying

We've seen a number of workflows failing with `No space left on device`
error (e.g.
https://github.com/keep-network/keep-ecdsa/actions/runs/924123923).
The problem was a combination of a big cache size and significant memory
allocation after building Docker image.
According to moby/buildkit#1850:
"At the moment caches are copied over the existing cache so it keeps
growing".
As a temporary fix (until issue gets fixed by GH), we introduce a step
that moves the cache (similarily to how it's described in
moby/buildkit#1896).

The solution may not keep us from failures forever, as we still may
hit the problems with the full memory if the size of the Docker image
or cache increases (see this FD discussion:
https://www.flowdock.com/app/cardforcoin/tech/threads/Clml1_lI4HYRKrr3N_vcSInDn6A).
@michalinacienciala michalinacienciala requested a review from nkuba June 10, 2021 11:26
@beaurancourt
Copy link

Given that this is an exact port over from https://github.com/docker/build-push-action/blob/master/docs/advanced/cache.md#github-cache, I think we're good here!

@beaurancourt beaurancourt self-requested a review June 10, 2021 13:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants