Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datasets #128

Merged
merged 45 commits into from
Nov 11, 2017
Merged

Datasets #128

merged 45 commits into from
Nov 11, 2017

Commits on Jul 26, 2017

  1. Configuration menu
    Copy the full SHA
    415c417 View commit details
    Browse the repository at this point in the history
  2. Add Datasets and relevant models

    Sha committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    6b553e1 View commit details
    Browse the repository at this point in the history
  3. Add a query definition model

    Sha committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    9e59776 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4fc9a8b View commit details
    Browse the repository at this point in the history
  5. Add unit test for QueryDatasetAsync

    Sha committed Jul 26, 2017
    Configuration menu
    Copy the full SHA
    5b9643f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    6f3a5b4 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2017

  1. Configuration menu
    Copy the full SHA
    fec9c16 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7c98001 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4a5b56f View commit details
    Browse the repository at this point in the history
  4. Move IDataset into it's own file

    Sha committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    0394b1d View commit details
    Browse the repository at this point in the history
  5. Clean up scope of using statements

    Always using outside of namespace.
    Sha committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    fd294c4 View commit details
    Browse the repository at this point in the history
  6. Fix scope of SnakeCasecontractResolver

    We don't need to expose this in the client.
    Sha committed Aug 11, 2017
    Configuration menu
    Copy the full SHA
    e0a6ebb View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2017

  1. Configuration menu
    Copy the full SHA
    ac0e91f View commit details
    Browse the repository at this point in the history
  2. Clean up usings

    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    6f5b3ec View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0ed3fb2 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c39aa24 View commit details
    Browse the repository at this point in the history
  5. Added Put methods to KeenHttpClient

    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    d6425ca View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    dae4202 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    4b42fce View commit details
    Browse the repository at this point in the history
  8. Add XML comments to public facing methods

    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    891b1ae View commit details
    Browse the repository at this point in the history
  9. Remove models which are not used

    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    c2602e9 View commit details
    Browse the repository at this point in the history
  10. Fix minor typo in DeleteDataset

    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    5c2c2ac View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    3fcb789 View commit details
    Browse the repository at this point in the history
  12. Update dataset tests to test sync methods instead of async ones

    Because the sync ones end up calling the async ones. This way all the dataset methods on KeenClient are covered.
    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    7b98a80 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    306cdaa View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2e69245 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    16e3fc8 View commit details
    Browse the repository at this point in the history
  16. Merge branch 'master' into cached-datasets

    Sha committed Aug 17, 2017
    Configuration menu
    Copy the full SHA
    883f1eb View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2017

  1. Configuration menu
    Copy the full SHA
    ff25092 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2017

  1. Include testing for Create and Delete datasets

    Also refactored the tests to be a bit neater
    Sha committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    7674dc4 View commit details
    Browse the repository at this point in the history
  2. Add tests for dataset error modes

    Sha committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    f90189c View commit details
    Browse the repository at this point in the history
  3. Clean up scope of imports

    Sha committed Aug 21, 2017
    Configuration menu
    Copy the full SHA
    16b6f51 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2017

  1. Merge remote-tracking branch 'github/master' into jm_UpdateCachedData…

    …setsBranch
    
    # Conflicts:
    #	Keen/KeenConstants.cs
    masojus committed Oct 26, 2017
    Configuration menu
    Copy the full SHA
    7c3c8ef View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2017

  1. Configuration menu
    Copy the full SHA
    b9d6f59 View commit details
    Browse the repository at this point in the history
  2. No need for a SnakeCaseContractResolver since Json.NET has a `Snake…

    …CaseNamingStrategy`, so use that.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    2f68d98 View commit details
    Browse the repository at this point in the history
  3. More PR Feedback--no need to use these custom converters:

    - The back end actually supports receiving either string or list of strings for both `index_by` and `group_by`.
    - In both cases it returns a list anyway.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    ed82ebb View commit details
    Browse the repository at this point in the history
  4. More PR feedback:

    - A few comments/whitespace/formatting issues.
    - Share code between PutAsync()/PostAsync().
    - Move QueryDefinition extensions that are specifically for datasets to the `Keen.Core.Dataset` namespace.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    f9906fc View commit details
    Browse the repository at this point in the history
  5. Swap the contents of DatasetTests and DataSetTests_Integration an…

    …d also fix capitalization.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    a1e13a1 View commit details
    Browse the repository at this point in the history
  6. Rename methods to *Async() since they return Tasks.

    - Still need to add or elaborate on comments for lots of public members.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    bb4aab9 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7379005 View commit details
    Browse the repository at this point in the history
  8. Port Datasets to NetStandard:

    - At this point all the tests pass, at least.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    74d10c3 View commit details
    Browse the repository at this point in the history
  9. This should make tests be able to load those JSON files from a local …

    …path in Windows, Linux and MacOS without issue.
    masojus committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    81e3f4d View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2017

  1. Configuration menu
    Copy the full SHA
    9638f01 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2017

  1. Responding to some PR Feedback:

    - Regarding *Async() methods in KeenClient.cs, for simple forwarding methods, just return the task directly. No need to await or configure the awaiter...either way, internally our impls configure awaiters properly everywhere, and a 3rd party impl of, say IQueries could fail to do so and cause blocking on our task to potentially deadlock anyway, depending on the sync ctx. Anywhere there are calls to multiple async APIs we go ahead and await/configure as expected.
    - One actual ramification of returning tasks is that in a few places where we validate params, we'll throw synchronously now instead of when the task is awaited, so potentially if you call us and store the task to await later, the client code's try/catch could be in the wrong place, but that seems like it's not that huge a deal as long as we bump the minor version (still pre-v1.0).
    - Some of the Datasets code was incorrectly demanding a MasterKey when it really only needs a ReadKey.
    - Changing to ReadKey showed me that some of the tests that expect throwing situations wouldn't catch the wrong key, because we throw the same exception for the server returning 500 as for an incorrect key (KeenException). This could mean we should throw different exceptions, which would make testing this easier (and potentially make coding against the SDK easier). It could also be fixed in tests by checking for certain words in the error message, but I figured it was more straightforward and clear to separate that particular throwing condition into its own test for each of the create/result/definition(s)/delete functions.
    - Changed GetQueries()->GetQueriesAsync(), since it's public and should indicate that it returns an awaitable.
    masojus committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    747b9c7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f73aa1d View commit details
    Browse the repository at this point in the history