-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Datasets #128
Datasets #128
Commits on Jul 26, 2017
-
Add SnakeCaseContractResolved for deserializing responses to CLR types
Sha committedJul 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 415c417 - Browse repository at this point
Copy the full SHA 415c417View commit details -
Add Datasets and relevant models
Sha committedJul 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 6b553e1 - Browse repository at this point
Copy the full SHA 6b553e1View commit details -
Sha committed
Jul 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 9e59776 - Browse repository at this point
Copy the full SHA 9e59776View commit details -
Add functions in KeenClient to query Datasets and their definitions
Sha committedJul 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 4fc9a8b - Browse repository at this point
Copy the full SHA 4fc9a8bView commit details -
Add unit test for QueryDatasetAsync
Sha committedJul 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 5b9643f - Browse repository at this point
Copy the full SHA 5b9643fView commit details -
Merge remote-tracking branch 'keenlabs/master' into cached-datasets
Sha committedJul 26, 2017 Configuration menu - View commit details
-
Copy full SHA for 6f3a5b4 - Browse repository at this point
Copy the full SHA 6f3a5b4View commit details
Commits on Aug 11, 2017
-
Fix typo on private field: _cachedDatasetRelativeUrl
Sha committedAug 11, 2017 Configuration menu - View commit details
-
Copy full SHA for fec9c16 - Browse repository at this point
Copy the full SHA fec9c16View commit details -
Provide XML comments for all new public facing methods
Sha committedAug 11, 2017 Configuration menu - View commit details
-
Copy full SHA for 7c98001 - Browse repository at this point
Copy the full SHA 7c98001View commit details -
Provide XML comments for the dataset classes exposed via KeenClient
Sha committedAug 11, 2017 Configuration menu - View commit details
-
Copy full SHA for 4a5b56f - Browse repository at this point
Copy the full SHA 4a5b56fView commit details -
Move IDataset into it's own file
Sha committedAug 11, 2017 Configuration menu - View commit details
-
Copy full SHA for 0394b1d - Browse repository at this point
Copy the full SHA 0394b1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for fd294c4 - Browse repository at this point
Copy the full SHA fd294c4View commit details -
Fix scope of SnakeCasecontractResolver
We don't need to expose this in the client.
Sha committedAug 11, 2017 Configuration menu - View commit details
-
Copy full SHA for e0a6ebb - Browse repository at this point
Copy the full SHA e0a6ebbView commit details
Commits on Aug 17, 2017
-
Rename Dataset.cs and provide serialization and validation utility
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for ac0e91f - Browse repository at this point
Copy the full SHA ac0e91fView commit details -
Sha committed
Aug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 6f5b3ec - Browse repository at this point
Copy the full SHA 6f5b3ecView commit details -
Added class for fetching lists of dataset definitions
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 0ed3fb2 - Browse repository at this point
Copy the full SHA 0ed3fb2View commit details -
Added Validation and Serialization utility for QueryDefinition
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for c39aa24 - Browse repository at this point
Copy the full SHA c39aa24View commit details -
Added Put methods to KeenHttpClient
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for d6425ca - Browse repository at this point
Copy the full SHA d6425caView commit details -
Implement Create, Delete and Get All for Cached Datasets
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for dae4202 - Browse repository at this point
Copy the full SHA dae4202View commit details -
Added sync methods for Create, Delete and List Cached Datasets
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 4b42fce - Browse repository at this point
Copy the full SHA 4b42fceView commit details -
Add XML comments to public facing methods
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 891b1ae - Browse repository at this point
Copy the full SHA 891b1aeView commit details -
Remove models which are not used
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for c2602e9 - Browse repository at this point
Copy the full SHA c2602e9View commit details -
Fix minor typo in DeleteDataset
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 5c2c2ac - Browse repository at this point
Copy the full SHA 5c2c2acView commit details -
Add some simple tests for the new dataset methods
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 3fcb789 - Browse repository at this point
Copy the full SHA 3fcb789View commit details -
Update dataset tests to test sync methods instead of async ones
Because the sync ones end up calling the async ones. This way all the dataset methods on KeenClient are covered.
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 7b98a80 - Browse repository at this point
Copy the full SHA 7b98a80View commit details -
Use shared GetSerializerSettings function for getdatasetdefinition
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 306cdaa - Browse repository at this point
Copy the full SHA 306cdaaView commit details -
Add testing for the custom serialization logic
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 2e69245 - Browse repository at this point
Copy the full SHA 2e69245View commit details -
Added teast for serializing datasetdefinitioncollection
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 16e3fc8 - Browse repository at this point
Copy the full SHA 16e3fc8View commit details -
Merge branch 'master' into cached-datasets
Sha committedAug 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 883f1eb - Browse repository at this point
Copy the full SHA 883f1ebView commit details
Commits on Aug 18, 2017
-
Fix bug with ListDatasetDefinition that popped up in unit tests
Sha committedAug 18, 2017 Configuration menu - View commit details
-
Copy full SHA for ff25092 - Browse repository at this point
Copy the full SHA ff25092View commit details
Commits on Aug 21, 2017
-
Include testing for Create and Delete datasets
Also refactored the tests to be a bit neater
Sha committedAug 21, 2017 Configuration menu - View commit details
-
Copy full SHA for 7674dc4 - Browse repository at this point
Copy the full SHA 7674dc4View commit details -
Add tests for dataset error modes
Sha committedAug 21, 2017 Configuration menu - View commit details
-
Copy full SHA for f90189c - Browse repository at this point
Copy the full SHA f90189cView commit details -
Sha committed
Aug 21, 2017 Configuration menu - View commit details
-
Copy full SHA for 16b6f51 - Browse repository at this point
Copy the full SHA 16b6f51View commit details
Commits on Oct 26, 2017
-
Merge remote-tracking branch 'github/master' into jm_UpdateCachedData…
…setsBranch # Conflicts: # Keen/KeenConstants.cs
Configuration menu - View commit details
-
Copy full SHA for 7c3c8ef - Browse repository at this point
Copy the full SHA 7c3c8efView commit details
Commits on Nov 4, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b9d6f59 - Browse repository at this point
Copy the full SHA b9d6f59View commit details -
No need for a
SnakeCaseContractResolver
since Json.NET has a `Snake……CaseNamingStrategy`, so use that.
Configuration menu - View commit details
-
Copy full SHA for 2f68d98 - Browse repository at this point
Copy the full SHA 2f68d98View commit details -
More PR Feedback--no need to use these custom converters:
- The back end actually supports receiving either string or list of strings for both `index_by` and `group_by`. - In both cases it returns a list anyway.
Configuration menu - View commit details
-
Copy full SHA for ed82ebb - Browse repository at this point
Copy the full SHA ed82ebbView commit details -
- A few comments/whitespace/formatting issues. - Share code between PutAsync()/PostAsync(). - Move QueryDefinition extensions that are specifically for datasets to the `Keen.Core.Dataset` namespace.
Configuration menu - View commit details
-
Copy full SHA for f9906fc - Browse repository at this point
Copy the full SHA f9906fcView commit details -
Swap the contents of
DatasetTests
andDataSetTests_Integration
an……d also fix capitalization.
Configuration menu - View commit details
-
Copy full SHA for a1e13a1 - Browse repository at this point
Copy the full SHA a1e13a1View commit details -
Rename methods to
*Async()
since they returnTask
s.- Still need to add or elaborate on comments for lots of public members.
Configuration menu - View commit details
-
Copy full SHA for bb4aab9 - Browse repository at this point
Copy the full SHA bb4aab9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7379005 - Browse repository at this point
Copy the full SHA 7379005View commit details -
- At this point all the tests pass, at least.
Configuration menu - View commit details
-
Copy full SHA for 74d10c3 - Browse repository at this point
Copy the full SHA 74d10c3View commit details -
This should make tests be able to load those JSON files from a local …
…path in Windows, Linux and MacOS without issue.
Configuration menu - View commit details
-
Copy full SHA for 81e3f4d - Browse repository at this point
Copy the full SHA 81e3f4dView commit details
Commits on Nov 10, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 9638f01 - Browse repository at this point
Copy the full SHA 9638f01View commit details
Commits on Nov 11, 2017
-
Responding to some PR Feedback:
- Regarding *Async() methods in KeenClient.cs, for simple forwarding methods, just return the task directly. No need to await or configure the awaiter...either way, internally our impls configure awaiters properly everywhere, and a 3rd party impl of, say IQueries could fail to do so and cause blocking on our task to potentially deadlock anyway, depending on the sync ctx. Anywhere there are calls to multiple async APIs we go ahead and await/configure as expected. - One actual ramification of returning tasks is that in a few places where we validate params, we'll throw synchronously now instead of when the task is awaited, so potentially if you call us and store the task to await later, the client code's try/catch could be in the wrong place, but that seems like it's not that huge a deal as long as we bump the minor version (still pre-v1.0). - Some of the Datasets code was incorrectly demanding a MasterKey when it really only needs a ReadKey. - Changing to ReadKey showed me that some of the tests that expect throwing situations wouldn't catch the wrong key, because we throw the same exception for the server returning 500 as for an incorrect key (KeenException). This could mean we should throw different exceptions, which would make testing this easier (and potentially make coding against the SDK easier). It could also be fixed in tests by checking for certain words in the error message, but I figured it was more straightforward and clear to separate that particular throwing condition into its own test for each of the create/result/definition(s)/delete functions. - Changed GetQueries()->GetQueriesAsync(), since it's public and should indicate that it returns an awaitable.
Configuration menu - View commit details
-
Copy full SHA for 747b9c7 - Browse repository at this point
Copy the full SHA 747b9c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f73aa1d - Browse repository at this point
Copy the full SHA f73aa1dView commit details