Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warnings when integrating via CocoaPods #246

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

MaximeLM
Copy link

Fixes the 110 warnings that are generated when integrating Keen 3.7.0 in an iOS app using Xcode 10:

  • Bump deployment target to iOS 8:
    • iOS 7 is no longer supported by the iOS simulator
    • fixes NSURLSession warnings
  • Fix strict_prototypes warnings
  • Disable Block implicitly retains 'self' warnings in podspec; the changes required by this warning are quite important, so I chose to disable the warning in the podspec instead
  • Update deprecated CLLocationManagerDelegate method

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 66.165% when pulling a246a23 on MaximeLM:fix_cocoapods_warnings into da11140 on keenlabs:master.

@MaximeLM
Copy link
Author

Not sure why the travis build failed, looks like a ruby/cocoapods issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants