Skip to content

Submitting Pull Requests

Keefer Rourke edited this page Sep 3, 2017 · 2 revisions

Submitting Pull Requests

The guidelines for submitting a pull request are much looser than icon request submissions. In general I just want the following information:

  • a brief description of the changes that you've made
  • justification for why the changes were made

Submitting new icons or icon revisions

Community submissions are welcome, provided that they fit with the macOS / Material hybrid design that the rest of La Capitaine follows. When submitting new desktop application icons (or revisions to existing icons), I request that you also attach a 128x128 raster copy of the icon in your pull request, as well as the information listed above.

If you are making a new icon, please use the provided template. Instructions are provided inside the template file.

Example pull request with new icons

New dialog-password icon

The current status/scalable/dialog-password icon doesn't match the style of La Capitaine very well.

I revised the icon based on the existing preferences-system-privacy and encrypted-key icons.

    old               new

dialog-password (old)     dialog-password (new)

The above format allows me to quickly, at a glance decide if the change should be merged. If there is an issue or something that I don't like, I can quickly start a conversation with you to point out what should be changed in order for the pull request to be accepted. This makes everyone's lives easier 😄