Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import path for get_kedro_project_json_data #143

Closed
jitu5 opened this issue Oct 31, 2024 · 0 comments · Fixed by #152
Closed

Update import path for get_kedro_project_json_data #143

jitu5 opened this issue Oct 31, 2024 · 0 comments · Fixed by #152
Assignees
Labels
dependencies Pull requests that update a dependency file Kedro-Viz Functionality/Fix needs to done from Kedro-Viz Python Pull requests that update Python code

Comments

@jitu5
Copy link
Contributor

jitu5 commented Oct 31, 2024

Description

In next release Kedro-Viz will move get_kedro_project_json_data from kedro_viz.api.rest.responses to kedro_viz.api.rest.responses.pipelines after recent refactor.

Possible solution

To support both 10.0.0 and late version

try:
    from kedro_viz.api.rest.responses.pipelines import get_kedro_project_json_data
except ImportError as e:
    from kedro_viz.api.rest.responses import get_kedro_project_json_data    

Note: We need to fix this before next Kedro-Viz release.

@jitu5 jitu5 self-assigned this Oct 31, 2024
@jitu5 jitu5 added Kedro-Viz Functionality/Fix needs to done from Kedro-Viz dependencies Pull requests that update a dependency file Python Pull requests that update Python code labels Oct 31, 2024
@jitu5 jitu5 added this to Kedro-Viz Nov 13, 2024
@jitu5 jitu5 moved this to Todo in Kedro-Viz Nov 13, 2024
@jitu5 jitu5 moved this from In Progress to In Review in Kedro-Viz Nov 14, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Kedro-Viz Functionality/Fix needs to done from Kedro-Viz Python Pull requests that update Python code
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant