-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update get_kedro_project_json_data
import path
#152
Conversation
Signed-off-by: Jitendra Gundaniya <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still needed after #155? Would you bump the minimum version of kedro-viz to 10.1.0 after this?
Yes, as #155 updates the NPM and not pypi, Also we need to update this
I will update the minimum version of kedro-viz to 10.1.0 in this PR only |
Signed-off-by: Jitendra Gundaniya <[email protected]>
I suppose we will have to be careful abt making such changes on kedro-viz in the future as it is a breaking change on vscode. |
@rashidakanchwala It is technically a breaking change since it's public API. It's ok to do the refactor but you may need to leave the import in the original place temporarily to keep it non-breaking until 11.0.0. i.e. keep this in kedro_viz.api.rest.responses.py from .pipelines import get_kedro_project_json_data |
Descriptions
Resolves #143
This pull request includes a change to the
bundled/tool/lsp_server.py
file to improve compatibility with different versions ofkedro-viz
. The most important change is the addition of a try-except block to handle imports forkedro-viz
versions greater than and equal to 10.0.0.Developer Note
bundled/tool/lsp_server.py
: Added a try-except block to importget_kedro_project_json_data
from the correct module based on thekedro-viz
version.