Docs/issue 465 exclude spark tests information #485
Conversation
| > *Note:* If the tests in `tests/extras/datasets/spark` are failing, and you are | ||
| > not planning to work on Spark related features, then you can run a reduced | ||
| > test suite that excludes them. Do this by executing the following command: | ||
| > `make test-no-spark`. |
There was a problem hiding this comment.
You will need to leave a blank line between "...command:" and the code block, otherwise it will not render.
There was a problem hiding this comment.
You mean you would like it to render as a separate code block instead of inline?
There was a problem hiding this comment.
Please. If you have a colon introducing the code, I'd expect to see a separate code block.
Otherwise I'd expect it to read "Do this by executing make test-no-spark." without any extra words like following. If it's inline, it's not following.
There was a problem hiding this comment.
I like your "Do this by executing make test-no-spark" suggestion! Should I use that or would you like to change it directly? P.S. As mentioned in the PR description please feel free to change things directly if you have better formulations. I am not a native English speaker nor a professional writer. 😄
There was a problem hiding this comment.
Thanks! OK, I'll make this change when I next go into the docs and it'll filter through in due course :)
Description
Why was this PR created?
Addresses #465. Feel free to adapt the sentence.
Development notes
contributing.md.Checklist
Opened this PR as a 'Draft Pull Request' if it is work-in-progressUpdated the documentation to reflect the code changesRELEASE.mdfileAdded tests to cover my changesNotice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.
I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.