-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve OmegaConfigLoader performance #4367
Conversation
…into chore/improve-ocl
34 % reduction, not bad 👏🏼 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good to me, thanks @ravi-kumar-pilla!
I have tested the PR and have the same findings, the bottleneck of resolver has been removed with caching mechanism implemented in this PR, but there are bottlenecks remains from OmegaConf. I have reduce the issue into a single large config with no resolver involved. It can be benchmark with from omegaconf import OmegaConf
OmegaConf.load(path) or
This takes a significant time to run compare to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with comments to reference in the future. Also please update the release notes.
Signed-off-by: ravi_kumar_pilla <[email protected]>
Description
Resolves #4322
Development notes
_get_globals_value
and_get_runtime_value
by not re-creating_globals
andruntime_params
for each reference in the catalogOmegaConf.load
OmegaConf.to_container
OmegaConf.merge
Test Data
Before:
After:
Observation:
There is a slight improvement in the performance as seen above
Developer Certificate of Origin
We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a
Signed-off-by
line in the commit message. See our wiki for guidance.If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.
Checklist
RELEASE.md
file