Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Update MLflow docs page in #3856 #3862

Merged
merged 2 commits into from
May 13, 2024

Conversation

stichbury
Copy link
Contributor

Description

Fork PR because I'm not a maintainer

Development notes

Few suggested fixes and Vale cleanup

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

stichbury added 2 commits May 10, 2024 12:34
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
@astrojuanlu
Copy link
Member

Merging this straight away to continue the discussion in the main PR

@astrojuanlu astrojuanlu merged commit aedab89 into kedro-org:docs/kedro-mlflow May 13, 2024
2 of 3 checks passed
astrojuanlu added a commit that referenced this pull request Jun 6, 2024
* Describe integration with MLflow

Closes #3541.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* [Docs] Update MLflow docs page in #3856 (#3862)

* Some proposed edits

Signed-off-by: Jo Stichbury <[email protected]>

* Fix some Vale warnings

Signed-off-by: Jo Stichbury <[email protected]>

---------

Signed-off-by: Jo Stichbury <[email protected]>

* Simplify MLflow launch

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add label to runtime params section

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Restructure MLflow document

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Apply suggestions from code review

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
bpmeek pushed a commit to bpmeek/kedro that referenced this pull request Jun 20, 2024
* Describe integration with MLflow

Closes kedro-org#3541.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* [Docs] Update MLflow docs page in kedro-org#3856 (kedro-org#3862)

* Some proposed edits

Signed-off-by: Jo Stichbury <[email protected]>

* Fix some Vale warnings

Signed-off-by: Jo Stichbury <[email protected]>

---------

Signed-off-by: Jo Stichbury <[email protected]>

* Simplify MLflow launch

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add label to runtime params section

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Restructure MLflow document

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Apply suggestions from code review

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: bpmeek <[email protected]>
bpmeek pushed a commit to bpmeek/kedro that referenced this pull request Jun 20, 2024
* Describe integration with MLflow

Closes kedro-org#3541.

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* [Docs] Update MLflow docs page in kedro-org#3856 (kedro-org#3862)

* Some proposed edits

Signed-off-by: Jo Stichbury <[email protected]>

* Fix some Vale warnings

Signed-off-by: Jo Stichbury <[email protected]>

---------

Signed-off-by: Jo Stichbury <[email protected]>

* Simplify MLflow launch

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add label to runtime params section

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Restructure MLflow document

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Apply suggestions from code review

Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Apply suggestions from code review

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Nok Lam Chan <[email protected]>
Signed-off-by: bpmeek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants