Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add migration steps for
ConfigLoader
toOmegaConfigLoader
#2887Add migration steps for
ConfigLoader
toOmegaConfigLoader
#2887Changes from 6 commits
28fa916
25f89f1
798f608
04bdf71
c2d3c8e
ffe59d7
bd624f9
1e8b76c
abaa815
de9c3b2
f418cdc
ff7d163
5dfe57b
b439645
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I correct in thinking this guide is mostly flagging differences rather than a full set of migration steps. So, in this section, you're showing where errors could be different. Are there things that are the same that you need to call out, as in "For error and exception handling, most errors are the same. Those you need to be aware of that are different between the original
ConfigLoader
andOmegaConfigLoader
are as follows:"Or is everything different, and set out below ? I'm just thinking about setting user expectations I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I have indeed mostly focussed on differences, because all the other behaviour is still the same. This section about errors is quite specific and most users probably won't care, but I added it in case users are catching a specific type of error and need to now change that. I'll add the sentence in mentioning most errors are still the same.