Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2498 Adding logging issue 2498 #2842

Merged
merged 9 commits into from
Aug 8, 2023
Merged

Fix #2498 Adding logging issue 2498 #2842

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
107af3f
Fixing typo n on line 114 file /docs/source/nodes_and_pipelines/run_a…
laizaparizotto Jul 21, 2023
cc6c1af
Removed redundant packages at lines 66, 67 and 68 on file kedro/docs/…
laizaparizotto Jul 21, 2023
ededf44
Fix #2498 Adding logging to function _get_default_version for micropa…
laizaparizotto Jul 25, 2023
81b52c8
Add logger object for logging when computing micropackage version
laizaparizotto Jul 26, 2023
1b83a3a
Merge branch 'kedro-org:main' into adding-logging-issue-2498
laizaparizotto Jul 27, 2023
b746f3e
Added new format to the logging
laizaparizotto Jul 27, 2023
004139b
Merge branch 'kedro-org:main' into adding-logging-issue-2498
laizaparizotto Jul 27, 2023
bdc4c04
Merge branch 'main' into adding-logging-issue-2498
laizaparizotto Aug 1, 2023
e4eff5a
Merge branch 'main' into adding-logging-issue-2498
merelcht Aug 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions kedro/framework/cli/micropkg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
from typing import Any, Iterable, Iterator, List, Tuple, Union

import click
import logging
from build.util import project_wheel_metadata
from packaging.requirements import InvalidRequirement, Requirement
from packaging.utils import canonicalize_name
Expand Down Expand Up @@ -592,6 +593,7 @@ def _get_default_version(metadata: ProjectMetadata, micropkg_module_path: str) -
)
return micropkg_module.__version__ # type: ignore
except (AttributeError, ModuleNotFoundError):
logger.warning(f"Micropackage version not found in '{metadata.package_name}.{micropkg_module_path}', will take the top-level one in '{metadata.package_name}'")
# if micropkg version doesn't exist, take the project one
project_module = import_module(f"{metadata.package_name}")
return project_module.__version__ # type: ignore
Expand Down