Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issues 2607 redundant packages #2827

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fixing issues 2607 redundant packages #2827

merged 2 commits into from
Jul 21, 2023

Conversation

laizaparizotto
Copy link
Contributor

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@laizaparizotto
Fixing typo n on line 114 file /docs/source/nodes_and_pipelines/run_a…
107af3f 
…_pipeline.md from issue kedro-org#2607

Signed-off-by: laizaparizotto <[email protected]>
@laizaparizotto
Removed redundant packages at lines 66, 67 and 68 on file kedro/docs/…
cc6c1af 
…source/nodes_and_pipelines/run_a_pipeline.md, packages: from kedro.io import AbstractDataSet, DataCatalog, MemoryDataSet, from kedro.pipeline import Pipeline and from kedro.runner.runner import AbstractRunner

Signed-off-by: laizaparizotto <[email protected]>
@noklam
Copy link
Contributor

noklam commented Jul 21, 2023 •
edited
Loading

Not sure about this, the import looks necessary to me, how does it work for DryRunner(AbstractRunner) if we are not importing it?

See my response in the OG issue

@opensean Hey! Thank you for spotting this, would you be open to creating a PR to fix this? I also did a quick check the import is not strictly needed, but they are there for type hints. Could you double check?

deepyaman
deepyaman approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! LGTM

@deepyaman
Copy link
Member

Not sure about this, the import looks necessary to me, how does it work for DryRunner(AbstractRunner) if we are not importing it?

See my response in the OG issue

@opensean Hey! Thank you for spotting this, would you be open to creating a PR to fix this? I also did a quick check the import is not strictly needed, but they are there for type hints. Could you double check?

@noklam I think it's just duplicated?

image

@noklam
Copy link
Contributor

noklam commented Jul 21, 2023

@deepyaman my bad, should have check the whole file😐

@noklam noklam self-requested a review July 21, 2023 16:26
noklam
noklam approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noklam noklam merged commit 5feb087 into kedro-org:main Jul 21, 2023
noklam pushed a commit that referenced this pull request Jul 24, 2023
@laizaparizotto @noklam
Fixing issues 2607 redundant packages (#2827)
e9ac9f0 
* Fixing typo n on line 114 file /docs/source/nodes_and_pipelines/run_a_pipeline.md from issue #2607

Signed-off-by: laizaparizotto <[email protected]>

* Removed redundant packages at lines 66, 67 and 68 on file kedro/docs/source/nodes_and_pipelines/run_a_pipeline.md, packages:  from kedro.io import AbstractDataSet, DataCatalog, MemoryDataSet,  from kedro.pipeline import Pipeline and  from kedro.runner.runner import AbstractRunner

Signed-off-by: laizaparizotto <[email protected]>

---------

Signed-off-by: laizaparizotto <[email protected]>
Signed-off-by: Nok <[email protected]>
@astrojuanlu astrojuanlu mentioned this pull request Aug 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noklam noklam noklam approved these changes

@deepyaman deepyaman deepyaman approved these changes

@yetudada yetudada Awaiting requested review from yetudada yetudada is a code owner

@astrojuanlu astrojuanlu Awaiting requested review from astrojuanlu astrojuanlu is a code owner

@stichbury stichbury Awaiting requested review from stichbury

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laizaparizotto @noklam @deepyaman