Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not unsuppress DeprecationWarnings with Kedro #2747

Merged
merged 2 commits into from
Jun 30, 2023

Conversation

deepyaman
Copy link
Member

@deepyaman deepyaman commented Jun 29, 2023

NOTE: Kedro datasets are moving from kedro.extras.datasets to a separate kedro-datasets package in
kedro-plugins repository. Any changes to the dataset implementations
should be done by opening a pull request in that repository.

Description

Development notes

Closes #2744

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes

@deepyaman deepyaman marked this pull request as ready for review June 29, 2023 16:00
@deepyaman deepyaman requested a review from idanov as a code owner June 29, 2023 16:00
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Although I'd note that, if users import kedro.extras.logging, they'll have a similar problem:

warnings.simplefilter("default", DeprecationWarning)

@deepyaman deepyaman enabled auto-merge (squash) June 30, 2023 01:58
@deepyaman deepyaman mentioned this pull request Jun 30, 2023
8 tasks
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@deepyaman deepyaman merged commit 9c49a65 into main Jun 30, 2023
@deepyaman deepyaman deleted the chore/do-not-unsuppress-deprecation-warnings branch June 30, 2023 15:12
AhdraMeraliQB pushed a commit that referenced this pull request Jun 30, 2023
* Do not unsuppress `DeprecationWarning`s with Kedro

Signed-off-by: Deepyaman Datta <[email protected]>

* Remove unused import

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>
AhdraMeraliQB added a commit that referenced this pull request Jul 3, 2023
* Update release date in CITATION.cff

Signed-off-by: Ahdra Merali <[email protected]>

* Rename old version to 0.18.11 where relevant

Signed-off-by: Ahdra Merali <[email protected]>

* Add Upcoming release section to RELEASE.md

Signed-off-by: Ahdra Merali <[email protected]>

* Fix prepopulated TOC

Signed-off-by: Ahdra Merali <[email protected]>

* Fix prepopulated TOC

Signed-off-by: Ahdra Merali <[email protected]>

* update release notes with documentation details

Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>

* Add note of deprecation warning to RELEASE.md

Signed-off-by: Ahdra Merali <[email protected]>

* Do not unsuppress `DeprecationWarning`s with Kedro (#2747)

* Do not unsuppress `DeprecationWarning`s with Kedro

Signed-off-by: Deepyaman Datta <[email protected]>

* Remove unused import

Signed-off-by: Deepyaman Datta <[email protected]>

---------

Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Ahdra Merali <[email protected]>

* Update RELEASE.md with deprecation table

Signed-off-by: Ahdra Merali <[email protected]>

* Update CITATION.cff

Signed-off-by: Ahdra Merali <[email protected]>

* Update CITATION.cff

Signed-off-by: Ahdra Merali <[email protected]>

* Update docs/source/configuration/advanced_configuration.md

Co-authored-by: Jo Stichbury <[email protected]>

* Update tutorial_template.md

* Add community contributions

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

* Add Prefect 2.0 docs update to changelog

Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>

---------

Signed-off-by: Ahdra Merali <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
Co-authored-by: Jo Stichbury <[email protected]>
Co-authored-by: Deepyaman Datta <[email protected]>
Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid setting warning filters globally
3 participants