-
Notifications
You must be signed in to change notification settings - Fork 910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not unsuppress DeprecationWarning
s with Kedro
#2747
Conversation
Signed-off-by: Deepyaman Datta <[email protected]>
Signed-off-by: Deepyaman Datta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Although I'd note that, if users import kedro.extras.logging
, they'll have a similar problem:
kedro/kedro/extras/logging/__init__.py
Line 10 in dde360a
warnings.simplefilter("default", DeprecationWarning) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
* Do not unsuppress `DeprecationWarning`s with Kedro Signed-off-by: Deepyaman Datta <[email protected]> * Remove unused import Signed-off-by: Deepyaman Datta <[email protected]> --------- Signed-off-by: Deepyaman Datta <[email protected]> Signed-off-by: Ahdra Merali <[email protected]>
* Update release date in CITATION.cff Signed-off-by: Ahdra Merali <[email protected]> * Rename old version to 0.18.11 where relevant Signed-off-by: Ahdra Merali <[email protected]> * Add Upcoming release section to RELEASE.md Signed-off-by: Ahdra Merali <[email protected]> * Fix prepopulated TOC Signed-off-by: Ahdra Merali <[email protected]> * Fix prepopulated TOC Signed-off-by: Ahdra Merali <[email protected]> * update release notes with documentation details Signed-off-by: Jo Stichbury <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> * Add note of deprecation warning to RELEASE.md Signed-off-by: Ahdra Merali <[email protected]> * Do not unsuppress `DeprecationWarning`s with Kedro (#2747) * Do not unsuppress `DeprecationWarning`s with Kedro Signed-off-by: Deepyaman Datta <[email protected]> * Remove unused import Signed-off-by: Deepyaman Datta <[email protected]> --------- Signed-off-by: Deepyaman Datta <[email protected]> Signed-off-by: Ahdra Merali <[email protected]> * Update RELEASE.md with deprecation table Signed-off-by: Ahdra Merali <[email protected]> * Update CITATION.cff Signed-off-by: Ahdra Merali <[email protected]> * Update CITATION.cff Signed-off-by: Ahdra Merali <[email protected]> * Update docs/source/configuration/advanced_configuration.md Co-authored-by: Jo Stichbury <[email protected]> * Update tutorial_template.md * Add community contributions Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> * Add Prefect 2.0 docs update to changelog Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> --------- Signed-off-by: Ahdra Merali <[email protected]> Signed-off-by: Jo Stichbury <[email protected]> Signed-off-by: Deepyaman Datta <[email protected]> Signed-off-by: Juan Luis Cano Rodríguez <[email protected]> Co-authored-by: Jo Stichbury <[email protected]> Co-authored-by: Deepyaman Datta <[email protected]> Co-authored-by: Juan Luis Cano Rodríguez <[email protected]>
Description
Development notes
Closes #2744
Checklist
RELEASE.md
file