Draft - Resolves configuration earlier & separate runtimes_params and meta_params #2504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nok Chan [email protected]
Description
runtime_params
earliermeta_params
will not be pass tocatalog
and avoid the validation problem.Development notes
Challenge 1 - Parameters resolved too late
Once we merge parameters in ConfigLoader, all
runtime_params
are merged. This is fine forparameters
, but when it's done forcatalog
-Challenge 2 - Works for parameters but not for other configs
We get invalid entries and we don't really want it. Same goes for logging. This wasn't an issue in #2467 because of an accident.
Currently this PR takes a simple solution - it is only enable for
parameters
and nothing else. This is actually the same problemof #2175, but was hidden because of the above logic.
kedro/kedro/config/omegaconf_config.py
Lines 276 to 278 in 7dcb60c
Checklist
RELEASE.md
file