-
Notifications
You must be signed in to change notification settings - Fork 914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collapse the docs ToC to reduce scrolling #2480
Conversation
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Okay, I think I'm starting to grasp what do you mean by tweaking the information architecture 😄 I think this is the way. Two comments in the implementation:
I drew inspiration from what Furo does: |
I think there's one more factor contributing to the excessive scrolling that is not related to the information architecture though, which is that the font size of the side bar is huge (20px on Kedro vs, say, 11.375px for Furo). But reducing the size makes the docs look weird, because there's too much horizontal space as I mentioned in #2394. |
Thanks, yes! I don't think that's information architecture so much as organisation, but the way my brain works, I can't quite focus on the detail until the irritant of scrolling is dealt with. Although this is more just a research PR than something we'll necessarily take forward. Agree with all your points -- my next step was to put some copy into the index pages. I hadn't realised I could hide all the links, nor the thing with naming everything |
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
would it be possible to visually distinguish ie with a larger font, or bold the parent headings? they used to be bigger i think and now they are the same size as their children when expanded |
Team, please take a look at the built docs The sidebar is compressed to show sections only (omitting headings and subsections): This is the current sidebar in the published docs: The advantages to the user is that they can see more swiftly what is included in the docs and navigate to the section they want. The disadvantage is that, while there's less scrolling, there's no more clicking. I'm proposing that we try this out and get some feedback on whether people like the layout. There is a BIG CAVEAT. Organisation of docs is still TBDWe haven't yet made any changes to organise the docs, except for changes to the onboarding content, which has recently been streamlined. So presently, the layout is imperfect. I've made these changes now so we have a control: we are comparing collapsed ToC against expanded ToC without any further revisions. But it does mean that, if we decide to go with this structure, we'll then make further changes on it, so don't have a full picture of the final layout. However, I personally think it'll only get better with new organisation and this is a significant improvement. What do you think? Please leave a comment! Another caveat 🤦♀️I haven't made changes to add text to all the "landing" pages of the sections, which index them. So while I've added a bit of text to the "Get started" landing and a lot to the tutorial landing some of the later landing pages are still blank right now. That will need to change before this is accepted and merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thrilled that we are collapsing the sidebar a bit, and that we're taking advantage of some underused Sphinx features!
Some very broad comments:
- Some toctrees are hidden, which results in empty pages. I don't think it harms if we show them, so at least readers don't have to go back to the sidebar to locate the page they want to read, especially for pages without content.
- We could add a few divisions. Thinking:
- User documentation (everything except the pages listed in the other sections)
- Advanced topics (Deployment, Extend Kedro, Hooks)
- API reference (the "kedro" section currently there)
- Developer documentation (Development, Contribute to Kedro)
- I'm wondering how many people really use IPython (not iPython by the way) and whether we could focus mostly on Jupyter "and other notebook platforms" (maybe this is for another PR). At the very least, don't think it's important enough to deserve being mentioned in the menu title.
Absolutely. That's covered by the "Another Caveat" section -- if we accept this there will be a chunk of work to add back content into the index/landing page for each section and introduce the table of contents.
Fantastic idea, yes.
That's a good spot, thanks. Will make a separate PR to get that change in. @astrojuanlu do you have any insights into @amandakys's question about whether we can increase the font/bold the header of each section as it opens? So it's really clear where you are in the hierarchy at a glance. |
Right, looks like both are computed to 16px on my computer. I gave this a try by pushing directly to this branch, please bear in mind that my CSS skills are more or less like this |
Just commenting here in terms of my "user" experience browsing the docs rather than worrying about any technical details or exactly what the right headings and sections should be... Overall I prefer this to the current sidebar, but I personally don't have a big problem with scrolling through the current one. Maybe that's just because I'm so used it from many years spend staring at our docs though - if people with fresh eyes (@amandakys and @astrojuanlu) think it's too much scrolling then I'm happy to take their word for it. The font size looks good and makes the hierarchy clear to me (I guess as a result of a889d42). There's two things I don't like so much about this, but it sounds like these are already on your radar:
So overall the collapsed sidebar gets 👍 from me but I'm not desperate to make the change if it's more effort than you think it's worth. |
I think that the children fonts could do with being slightly smaller still in comparison. I tried out 1.5rem and it looked alright to me. Also are we aware that the .current tag works differently depending if you click the text vs if you click the + to expand? The former expands and also pins the section to the top of the side bar (or so it tries, sometimes it shows some inconsistent behaviour when clicking very nested children) +1 to the idea of needing to rethink the headings and grouping we are providing. In the ideal case i think we should at least be able to provide a scroll bar that doesn't require any scrolling on first load. I am aware screen size makes a difference here, but on my 13" macbook that's 13 headings. |
Just looking at font size again, do the heading "Summary", "Node" etc. underneath "Kedro concepts" look bigger than the "Kedro concepts" heading itself? Or am I just imagining it? 🤔 Either way I guess maybe it's better to have children fonts slightly smaller in comparison like @amandakys suggested (though I guess it shouldn't get smaller and smaller every level you go down, just two sizes are needed?). |
I don't think you're imagining it -- I think @astrojuanlu made a PR to tweak them slightly. It's very subtle, maybe some bold would help too? |
Signed-off-by: Jo Stichbury <[email protected]>
I did it. I added some extra bold. It looks, OK. |
Signed-off-by: Jo Stichbury <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
Note to self: pages removed that need redirects when we merge this PR and make a release:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this ToC a lot more! It definitely reduces how much scrolling you need to do 👍
I'm not sure I understand @noklam -- the page looks the same in the new ToC and in the existing docs, once you expand the page called "Nodes". If it helps, I can pair with you to see where the issue is? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is wonderful work! Indeed the new ToC is much easier to navigate, and I think it's starting to look like https://diataxis.fr. A few comments:
- Only the
integrations
section does not have anindex.md
, maybe we could add it? - There is a very short
introduction/index.md
followed byintroduction/introduction.md
, maybe we could merge both? - There's a
faq/faq.md
that maybe could be replaced byfaq/index.md
?
Some of these will require extra redirections on Read the Docs.
And then, about the divisions, I'm not 100 % convinced by "Tutorial and basic Kedro usage" + "Kedro projects" + "Advanced usage". What about "Tutorials" + "Basic usage" + "Advanced usage"?
Thanks for the feedback @astrojuanlu -- I will make those suggestions you've noted for the pages and request re-review.
Absolutely agree that the sections are far from perfect. But I don't want to put the Config docs, Data Catalog and Nodes/Pipelines under "Advanced usage" right now. My goal is to have a very basic sectioning and then test with users and brainstorm in the team how to revise. I think we should keep what I have proposed as it's similar to how the docs look today, and doesn't change too much for the users beyond compressing things a bit. Then we have a baseline to discuss and improve further. Sound reasonable? |
Sounds good to me 💪🏽 |
Signed-off-by: Jo Stichbury <[email protected]>
…into collapse-my-toc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I like the compressed version more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the only outstanding thing from my side is turning faq/faq.md
into faq/index.md
, other than that this is good to go and I'm approving already 🚀 Thanks a lot @stichbury!
Thanks for the approval @astrojuanlu I'm going to leave the FAQ name change for now (and the other that turns |
Here are the built docs for review
This PR is response to a discussion with @amandakys and ticket #2477.
Thanks to the 'A' team (@amandakys, @astrojuanlu and @AntonyMilneQB) for some input at the draft stage. I've now made a set of changes that I think are worthy of consideration to commit as an ongoing part of our docs improvements.
I haven't made a raft of changes that reorganise content or made significant changes to build out proper index pages. I appreciate the feedback though. I want us now to put this live and poll our user-base about how it works for them and what else we can improve. We need to run a complete research process to get a roadmap of information architecture changes...this PR is just to give us the baseline to start the research.
In terms of CSS changes, again, let's hold off, since we will make some changes for rebranding anyway, and need the expertise of a front-end developer to do it properly.
TL;DR -- This is now ready for final review. Maybe from @yetudada @noklam @jmholzer or @merelcht and anyone else interested!