Add new logging config for CLI hooks manager #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SajidAlamQB
approved these changes
Nov 23, 2021
lorenabalan
approved these changes
Nov 23, 2021
5 tasks
Galileo-Galilei
pushed a commit
to Galileo-Galilei/kedro
that referenced
this pull request
Feb 19, 2022
lvijnck
pushed a commit
to lvijnck/kedro
that referenced
this pull request
Apr 7, 2022
Signed-off-by: Laurens Vijnck <[email protected]>
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1024, someone thought it was a good idea to tidy up the loggers a bit. Unfortunately, what said person didn't realise is that this resulted in an incredibly annoying message every time you execute a
kedrocommand outside a project...The reason for this is that the CLI hooks manager was trying to write to a file
logs/info.log, which didn't exist. Actually if we're not in a kedro project we shouldn't be trying to log messages to a file at all because that would be really annoying. I've added a special logging handler for this case which means that the message will only be shown on the console and not written to any file.The other instances where I had changed
logging.infoto the "correct" kedro logger were in:_register_hooks_setuptoolsSession.runDataCatalog.listThese are all ok because they're only ever called inside a kedro project, when we do want the info.log file.
Checklist
RELEASE.mdfile