Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimap props refactor: miniMapBtn & zoomToolBar #1982

Closed
wants to merge 4 commits into from
Closed

Minimap props refactor: miniMapBtn & zoomToolBar #1982

wants to merge 4 commits into from

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented Jul 16, 2024 •
edited
Loading

Description

Resolves #1969 (comment) point 2

Development notes

In redux state visible.miniMapBtn not just control the visibility of mini map button but also all the zoom toolbar buttons
Screenshot 2024-07-15 at 10 28 45 a m

After PR changes visible.miniMapBtn only control the visibility of mini map button and display.zoomToolbar now controls the visibility of all the zoom toolbar buttons (zoom out, zoom in and zoom reset)

QA notes

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@jitu5
Minimap prop refactor
9ba7058 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 self-assigned this Jul 16, 2024
@jitu5 jitu5 added the Javascript Pull requests that update Javascript code label Jul 16, 2024
ravi-kumar-pilla
ravi-kumar-pilla approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@jitu5
propTypes added
2f602cd 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5
Moving zoomToolbar into display
47b7414 
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 changed the title Minimap props refactor: miniMapBtn Minimap props refactor: miniMapBtn & zoomToolBar Jul 18, 2024
This was referenced Jul 18, 2024
Closed
Merged
Huongg
Huongg approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@Huongg Huongg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 no questions from my side. Thank you @jitu5

@jitu5
Copy link
Contributor Author

jitu5 commented Jul 22, 2024

Closing this PR as it already merged with #1992 to main.

@jitu5 jitu5 closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravi-kumar-pilla ravi-kumar-pilla ravi-kumar-pilla approved these changes

@rashidakanchwala rashidakanchwala rashidakanchwala approved these changes

@Huongg Huongg Huongg approved these changes

Assignees

@jitu5 jitu5

Labels
Javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jitu5 @Huongg @rashidakanchwala @ravi-kumar-pilla