Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor api tests for modular pipelines change #1940

Conversation

ravi-kumar-pilla
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla commented Jun 10, 2024

Description

Partially resolves #1899

Development notes

QA notes

  • This PR is part of a bigger refactor (Refactor Namespace Pipelines  #1897) of modular pipelines and is created to ease review process.
  • The CI build might fail as this PR is not self-sufficient

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

@ravi-kumar-pilla ravi-kumar-pilla changed the title split refactor modular pipelines api tests Refactor api tests for modular pipelines change Jun 10, 2024
@ravi-kumar-pilla ravi-kumar-pilla mentioned this pull request Jun 10, 2024
9 tasks
)


# [TODO: Need to better manage this fixture]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's still a TODO here. The fixture is really large and quite hard to read IMO. Can we perhaps come up with example pipelines with more self-explanatory names and variable names? dataset_1 etc is a bit hard to follow.. Or at least can we add more explicit notes that explain what each of these use_cases are for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @merelcht , Yes even I felt the same. So for now kept a TODO and added links in the docstring of the fixture so the devs can take a look. I wanted to get some help from reviewers on how to do this more efficiently.

Based on your suggestion, I will try to come up with more meaningful names and see if we can split the fixture into multiple parts for each use case. Thank you

Signed-off-by: ravi-kumar-pilla <[email protected]>
@ravi-kumar-pilla ravi-kumar-pilla marked this pull request as ready for review June 24, 2024 15:02
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huge improvement! The test fixtures are much easier to understand now. Thanks @ravi-kumar-pilla ⭐ ⭐ ⭐ !

Signed-off-by: ravi-kumar-pilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants