-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor api tests for modular pipelines change #1940
Refactor api tests for modular pipelines change #1940
Conversation
Signed-off-by: ravi-kumar-pilla <[email protected]>
package/tests/conftest.py
Outdated
) | ||
|
||
|
||
# [TODO: Need to better manage this fixture] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see there's still a TODO here. The fixture is really large and quite hard to read IMO. Can we perhaps come up with example pipelines with more self-explanatory names and variable names? dataset_1
etc is a bit hard to follow.. Or at least can we add more explicit notes that explain what each of these use_cases are for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @merelcht , Yes even I felt the same. So for now kept a TODO and added links in the docstring of the fixture so the devs can take a look. I wanted to get some help from reviewers on how to do this more efficiently.
Based on your suggestion, I will try to come up with more meaningful names and see if we can split the fixture into multiple parts for each use case. Thank you
Signed-off-by: ravi-kumar-pilla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a huge improvement! The test fixtures are much easier to understand now. Thanks @ravi-kumar-pilla ⭐ ⭐ ⭐ !
Signed-off-by: ravi-kumar-pilla <[email protected]>
Description
Partially resolves #1899
Development notes
viz
#1814QA notes
Checklist
RELEASE.md
file