Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kedro Viz Static Website hosting on Azure #1708
Kedro Viz Static Website hosting on Azure #1708
Changes from all commits
66f177d
cc7c144
a389a83
6528d36
5a9f2e1
b86b578
40003f8
0c879a8
5145ba4
26f6275
52827c2
c7ed79c
11ac321
42af3af
aff36ec
7ad0905
0ff98a2
2a4e00f
ecb6a05
39418aa
b18d547
8b504fb
9d683aa
2655d1a
2ac04fd
c258ec1
44241ca
40df81e
c9e2436
9c31fc4
e05630b
e1016e2
2868fa3
c934570
6572ce0
3758a53
09e1c4c
3b34d8a
9b9478a
bce7258
c27f419
496c2c4
bb2e6a9
cd05c91
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we reused logic from kedro? I don't think
abfs
is the only protocols supported by Azure. See https://github.com/fsspec/adlfsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are using Gen2 filesystem to build the remote path (we will mention this in our docs that azure deployment is supported with gen2 filesystem). Could you please point me to what reuse logic from kedro you are referring to ? Thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/kedro-org/kedro/blob/80ad182a220d691c77efc05cc4e2b36dcecb6ac7/kedro/io/core.py#L711
95% identical to
fsspec
to handle some extra edge cases. If this only supportabfs
it is fine too, but worth mentioning in the docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is
$web
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$web is the default container in AzureBlobStorage when someone enables static website hosting. We will mention this in the docs that the users need to have this container to use static hosting.