Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch general exeception when git fails #1380

Merged
merged 6 commits into from
Jun 9, 2023
Merged

Catch general exeception when git fails #1380

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
86f883a
Catch general exeception
noklam Jun 5, 2023
7e07977
Fix coverage
noklam Jun 6, 2023
b321460
Merge branch 'main' into fix-git-exception
noklam Jun 7, 2023
89dcbbb
Merge branch 'main' into fix-git-exception
tynandebold Jun 8, 2023
4da0245
Update Release Note
noklam Jun 8, 2023
6a69545
Merge branch 'main' of https://github.com/kedro-org/kedro-viz into fi…
tynandebold Jun 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,17 +5,14 @@ Please follow the established format:
- Use present tense (e.g. 'Add new feature')
- Include the ID number for the related PR (or PRs) in parentheses
-->
# Release 6.2.2

## Major features and improvements

- Show original node input and output names in metadata panel. (#1381)

# Release 6.2.1

## Major features and improvements

- Add support for new kedro-viz layer configuration in kedro-datasets. (#1373)
- Show original node input and output names in metadata panel. (#1381)
- Fix bug where git causing kedro-viz panic. (#1380)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this goes in bugs and fixes. but maybe we can move that in the release ticket.


# Release 6.2.0

Expand Down
3 changes: 3 additions & 0 deletions package/kedro_viz/integrations/kedro/sqlite_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ def _to_json(self) -> str:
value["branch"] = branch.name
except ImportError as exc: # pragma: no cover
logger.warning("%s:%s", exc.__class__.__name__, exc.msg)
except Exception as exc: # pragma: no cover
logger.warning("Something went wrong when fetching git metadata.")
logger.warning(exc)

if _is_json_serializable(value):
session_dict[key] = value
Expand Down