Adjust exp. tracking CSS to account for tall matplotlib images #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tynan DeBold <[email protected]>
tynandebold
requested review from
Huongg,
rashidakanchwala and
cvetankanechevska
Signed-off-by: Tynan DeBold <[email protected]>
cvetankanechevska
approved these changes
Oct 28, 2022
|
We leave the image size up to the developer who's saving the images. We'll then render whatever they save to their project, so it'll always be in the full quality that they saved it as. |
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Signed-off-by: Tynan DeBold <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tynan DeBold [email protected]
Description
Fixes #1144.
Development notes
I've adjusted the CSS to allow for very tall images in experiment tracking. Before this PR we were limiting the height and now we aren't.
QA notes
The run
2022-09-05T12.27.04.496Zhas a very tall image in there now. Check that run to see that the image isn't covering any of the other elements on the page like in the screenshot in the linked issue. I'll remove this test image before merging the PR.Checklist
RELEASE.mdfile