Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to disable preview for all when publishing Kedro-Viz #1870

Closed
1 task done
ravi-kumar-pilla opened this issue Apr 22, 2024 · 3 comments · Fixed by #1894 or #1895
Closed
1 task done

Enable users to disable preview for all when publishing Kedro-Viz #1870

ravi-kumar-pilla opened this issue Apr 22, 2024 · 3 comments · Fixed by #1894 or #1895

Comments

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Apr 22, 2024

Description

This would help users to enable/disable preview for all the datasets.

Context

  • Users would like to have preview enabled in the catalog or for kedro viz run locally, but would like to disable the preview for all the datasets when deploying to cloud providers

https://kedro-org.slack.com/archives/C03RKP2LW64/p1713469330441069

Possible Implementation

  • Introduce a --include-preview option for all kedro viz cli commands
  • Default the preview feature to False (need to be discussed)

Possible Alternatives

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Apr 26, 2024

had a Design PS session with @stephkaiser , @idanov, @yetudada and @iamelijahko . The following came out of discussion

  • Instead of using --include-preview or --exclude-preview, we'll switch to --preview=false/true.
  • By default, kedro viz deploy and kedro viz build will set --preview=false.
  • On the other hand, kedro viz and kedro viz run will set --preview=true by default to ensure easy discovery of the feature.
  • In the UI, users will specify whether they want to Enable or Disable preview before publishing. The backend will then create a JSON API both either with or without preview data based on the user's selection that will get pushed to cloud

@rashidakanchwala rashidakanchwala changed the title Add an option to include preview for kedro viz cli commands Enable users to disable preview for all when publishing Kedro-Viz Apr 29, 2024
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Apr 29, 2024
@rashidakanchwala rashidakanchwala moved this from Backlog to Todo in Kedro-Viz Apr 29, 2024
@stephkaiser stephkaiser moved this from Todo to In Progress in Kedro-Viz Apr 30, 2024
@stephkaiser
Copy link

Designs can be found here - https://www.figma.com/file/3kSpvIO1veLKfy9qHxuXwF/Kedro-WIP?type=design&node-id=1411-87299&mode=design&t=HEcOS0koRJ2SVfbX-4

@ravi-kumar-pilla
Copy link
Contributor Author

Hi Team,

Based on our discussions, This ticket will focus on enabling/disabling preview for all the datasets during publishing.

Publishing from CLI - Preview will be disabled by default. If the users want to have preview, they should run -

kedro viz build --include-preview for platform agnostic build
kedro viz deploy --include-preview for deploying viz instance on cloud

Publishing from UI - Preview will be enabled by default on local instance of kedro viz when someone runs kedro viz run. Now the users will have the preview enable/disable toggle on the publish pop-up through which they can control the deployable instance preview settings.

image

NOTE: kedro viz run will not have any flag to enable/disable preview. We will have a ticket in future where we can have preview enable/disable for local instance in settings panel of UI.

Thank you

@ravi-kumar-pilla ravi-kumar-pilla moved this from In Progress to In Review in Kedro-Viz May 21, 2024
@ravi-kumar-pilla ravi-kumar-pilla moved this from In Review to In Progress in Kedro-Viz May 21, 2024
@jitu5 jitu5 moved this from In Progress to In Review in Kedro-Viz May 21, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment