Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable/disable preview for all the datasets when publishing Kedro-Viz from UI #1895

Merged
merged 52 commits into from
Jun 12, 2024

Conversation

jitu5
Copy link
Contributor

@jitu5 jitu5 commented May 8, 2024

Description

Resolves #1870

On kedro viz run locally, now the users will have the preview enable/disable toggle(All dataset previews) on the publish pop-up through which they can control the deployable instance preview settings.
Screenshot 2024-05-21 at 10 26 49 a m

Development notes

  • Modified DeployerConfiguration class to accept is_all_previews_enabled from FE
  • Modified deployer.deploy function to accept is_all_previews_enabled
  • Updated tests

NOTE: There is an overlap between this PR and #1894 . Changed the base to ease reviews. This PR will be merged after #1894. Also the above mentioned UI changes is part of #1907 PR. This PR will merge before #1907
Also CLI flag name changes from --include-preview to --include-previews is added to part of this PR.

Checklist

  • Read the contributing guidelines
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added new entries to the RELEASE.md file
  • Added tests to cover my changes

jitu5 added 7 commits May 3, 2024 13:57
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: <>
@rashidakanchwala
Copy link
Contributor

This is definitely much better than removing the keys, and it's good because deploy() function is accessible both in CLI and UI, so we can add that preview_flag there. Also agree with Ravi in future, if there are more customisations we could consider a DeployDataConfig class. Thanks @jitu5 and @ravi-kumar-pilla , great thinking on this approach :D

jitu5 and others added 14 commits May 10, 2024 19:51
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: Jitendra Gundaniya <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
Signed-off-by: ravi-kumar-pilla <[email protected]>
@ravi-kumar-pilla ravi-kumar-pilla changed the base branch from main to feature/disable-preview May 17, 2024 01:01
Signed-off-by: ravi-kumar-pilla <[email protected]>
@jitu5 jitu5 marked this pull request as ready for review May 21, 2024 09:46
@ravi-kumar-pilla ravi-kumar-pilla self-requested a review May 29, 2024 17:29
Signed-off-by: Jitendra Gundaniya <[email protected]>
Copy link
Contributor

@ravi-kumar-pilla ravi-kumar-pilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Leaving a note for reference -

This looks good to be merged with disable-preview branch if we hope to merge FE changes to main at the same time. If not, we should wait for the FE changes to complete before merging this PR to main.

Base automatically changed from feature/disable-preview to main May 31, 2024 12:59
jitu5 added 2 commits May 31, 2024 14:10
Signed-off-by: <>

# Conflicts:
#	RELEASE.md
Signed-off-by: Jitendra Gundaniya <[email protected]>
@jitu5 jitu5 merged commit 497a128 into main Jun 12, 2024
40 checks passed
@jitu5 jitu5 deleted the feature/disable-preview-ui branch June 12, 2024 14:19
@SajidAlamQB SajidAlamQB mentioned this pull request Jul 25, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable users to disable preview for all when publishing Kedro-Viz
4 participants