Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move to pyproject.toml #1527

Closed
1 task done
rashidakanchwala opened this issue Sep 8, 2023 · 4 comments · Fixed by #1766
Closed
1 task done

Move to pyproject.toml #1527

rashidakanchwala opened this issue Sep 8, 2023 · 4 comments · Fixed by #1766
Assignees
@MehdiNV @ravi-kumar-pilla
Labels
Python Pull requests that update Python code

Comments

@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Sep 8, 2023 •
edited by tynandebold
Loading

Description

Kedro-viz currently has requirements.txt file which the users use to install all the requirements. We want to now move to pyproject.toml which is a newer way of dependency management.

Pyproject.toml has some advance features that will also make our depandabot much more .... smarter? ;)

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala rashidakanchwala added Issue: Feature Request Python Pull requests that update Python code labels Sep 8, 2023
@tynandebold tynandebold moved this to Inbox in Kedro-Viz Sep 8, 2023
@tynandebold
Copy link
Member

@rashidakanchwala is this only for the requirements.txt file or do you imagine we can also move on from setup.py and setup.cfg to use only pyproject.toml?

@tynandebold tynandebold moved this from Inbox to Backlog in Kedro-Viz Sep 13, 2023
@astrojuanlu
Copy link
Member

If I may - yes pyproject.toml can cover setup.py + setup.cfg + requirements.txt. The only tool that doesn't support pyproject.toml is flake8, but you're storing its config in package/.flake8 already anyway, so you should be good.

@astrojuanlu astrojuanlu mentioned this issue Oct 16, 2023
Closed
7 tasks
@tynandebold tynandebold moved this from Backlog to Todo in Kedro-Viz Oct 16, 2023
@MehdiNV MehdiNV moved this from Todo to In Progress in Kedro-Viz Oct 16, 2023
@MehdiNV MehdiNV moved this from In Progress to Todo in Kedro-Viz Oct 16, 2023
@MehdiNV MehdiNV moved this from Todo to In Progress in Kedro-Viz Oct 16, 2023
@tynandebold tynandebold mentioned this issue Oct 16, 2023
Closed
@ravi-kumar-pilla ravi-kumar-pilla moved this from In Progress to Done in Kedro-Viz Oct 24, 2023
@astrojuanlu
Copy link
Member

Unmerged PR #1584

astrojuanlu added a commit that referenced this issue Feb 26, 2024
@astrojuanlu @MehdiNV
Migrate to pyproject.toml
4453861 
Fix gh-1527

Co-authored-by: Mehdi Naderi Varandi <[email protected]>
Signed-off-by: Juan Luis Cano Rodríguez <[email protected]>
@astrojuanlu
Copy link
Member

This was never fixed

@astrojuanlu astrojuanlu reopened this Feb 26, 2024
@astrojuanlu astrojuanlu mentioned this issue Feb 26, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MehdiNV MehdiNV

@ravi-kumar-pilla ravi-kumar-pilla

Labels
Python Pull requests that update Python code
Projects
Kedro-Viz
Status: Done
Milestone
No milestone
5 participants
@astrojuanlu @tynandebold @MehdiNV @rashidakanchwala @ravi-kumar-pilla