Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update example test files #216

Merged
merged 5 commits into from
Apr 17, 2024
Merged

fix: Update example test files #216

merged 5 commits into from
Apr 17, 2024

Conversation

AhdraMeraliQB
Copy link
Contributor

@AhdraMeraliQB AhdraMeraliQB commented Apr 5, 2024

Motivation and Context

A spin-off from kedro-org/kedro#3782

  • Removes references to the deprecated kedro test command
  • Introduces an example test for testing pipelines
  • Adds src to pytest's pythonpath in pyproject.toml

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@astrojuanlu
Copy link
Member

I propose we mark this as draft until some of the discussions in kedro-org/kedro#3782 have settled (like whether we should be using class-based tests or not)

@AhdraMeraliQB AhdraMeraliQB marked this pull request as draft April 11, 2024 16:06
@AhdraMeraliQB AhdraMeraliQB marked this pull request as ready for review April 17, 2024 13:12
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ElenaKhaustova
Copy link
Contributor

The e2e tests are expected to fail bcs of this

@merelcht merelcht merged commit 580f7f0 into main Apr 17, 2024
10 of 19 checks passed
@merelcht merelcht deleted the fix/update-placeholder-tests branch April 17, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants