Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all starters use pyproject.toml #144

Merged
merged 4 commits into from
Aug 25, 2023

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Aug 23, 2023

Motivation and Context

This PR builds upon the approach outlined in #2583. Initially, we transition from setup.py to pyproject.toml, keeping them at the same level within the '/src' folder. Concurrently, we shift from setup.cfg to the .flake8 configuration files. In the subsequent phase, with the release of Kedro 0.19, we plan to move pyproject.toml up one directory level and merge it with the existing pyproject.toml file.

How has this been tested?

Tested manually:
kedro new --starter git+https://github.com/kedro-org/kedro-starters.git --directory spaceflights --checkout 2280-make-all-starters-use-pyprojecttoml

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

DimedS added 2 commits August 23, 2023 11:06
Signed-off-by: Dmitry Sorokin <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
@DimedS DimedS self-assigned this Aug 23, 2023
@DimedS DimedS linked an issue Aug 23, 2023 that may be closed by this pull request
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave a quick first inspection, all pyproject.toml files are lacking a final newline

@DimedS DimedS force-pushed the 2280-make-all-starters-use-pyprojecttoml branch from e7eb835 to bacd216 Compare August 23, 2023 11:43
@DimedS DimedS marked this pull request as ready for review August 24, 2023 08:39
@DimedS
Copy link
Member Author

DimedS commented Aug 24, 2023

Gave a quick first inspection, all pyproject.toml files are lacking a final newline

thanks, fixed it!

@DimedS DimedS requested review from noklam and astrojuanlu August 24, 2023 08:45
@astrojuanlu
Copy link
Member

3.10 jobs failing because of using an old PyYAML, see yaml/pyyaml#601 (comment)

we'd either have to bump the PyYAML dependency, or constrain Cython<3 in the build phase.

@DimedS
Copy link
Member Author

DimedS commented Aug 24, 2023

3.10 jobs failing because of using an old PyYAML, see yaml/pyyaml#601 (comment)

we'd either have to bump the PyYAML dependency, or constrain Cython<3 in the build phase.

@astrojuanlu, thank you for pointing that out. It indeed seems to be an issue with Python 3.10. Can you clarify who and why installed Cython in that case? Regardless, it might be a good idea to update our PyYAML requirements to match Kedro's: "PyYAML>=4.2, <7.0". Do you foresee any issues with this adjustment?

Signed-off-by: Dmitry Sorokin <[email protected]>
Copy link
Contributor

@noklam noklam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I didn't test because CI is passing.

@astrojuanlu
Copy link
Member

I think it's good that we move to the new PyYAML, thanks @DimedS !

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and kedro-org/kedro#2853 are ready to be merged 🔥

@DimedS DimedS merged commit 967eb44 into main Aug 25, 2023
@DimedS DimedS deleted the 2280-make-all-starters-use-pyprojecttoml branch August 25, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make all starters use pyproject.toml
3 participants