-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make all starters use pyproject.toml #144
Conversation
Signed-off-by: Dmitry Sorokin <[email protected]>
Signed-off-by: Dmitry Sorokin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gave a quick first inspection, all pyproject.toml
files are lacking a final newline
Signed-off-by: Dmitry Sorokin <[email protected]>
e7eb835
to
bacd216
Compare
thanks, fixed it! |
3.10 jobs failing because of using an old PyYAML, see yaml/pyyaml#601 (comment) we'd either have to bump the PyYAML dependency, or constrain Cython<3 in the build phase. |
@astrojuanlu, thank you for pointing that out. It indeed seems to be an issue with Python 3.10. Can you clarify who and why installed Cython in that case? Regardless, it might be a good idea to update our PyYAML requirements to match Kedro's: "PyYAML>=4.2, <7.0". Do you foresee any issues with this adjustment? |
Signed-off-by: Dmitry Sorokin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I didn't test because CI is passing.
I think it's good that we move to the new PyYAML, thanks @DimedS ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This and kedro-org/kedro#2853 are ready to be merged 🔥
Motivation and Context
This PR builds upon the approach outlined in #2583. Initially, we transition from
setup.py
topyproject.toml
, keeping them at the same level within the '/src' folder. Concurrently, we shift fromsetup.cfg
to the.flake8
configuration files. In the subsequent phase, with the release of Kedro 0.19, we plan to movepyproject.toml
up one directory level and merge it with the existingpyproject.toml
file.How has this been tested?
Tested manually:
kedro new --starter git+https://github.com/kedro-org/kedro-starters.git --directory spaceflights --checkout 2280-make-all-starters-use-pyprojecttoml
Checklist