Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update starters to use new /conf structure #141

Merged
merged 1 commit into from
Aug 7, 2023

Conversation

DimedS
Copy link
Member

@DimedS DimedS commented Aug 3, 2023

Motivation and Context

In previous updates #2856 and #2884, we modified the structure of the /conf folder to

├── conf
    └── base
	├── catalog_{pipeline-name}.yml          #blank files
	└── parameters_{pipeline-name}.yml       #blank files
        ├── catalog.yml          #blank files   
	└── parameters.yml       #blank files

This PR aims to align the structure of the starters accordingly. Notably, there are no starters with a 'catalog' folder, and only the spaceflights starter contains a 'parameters' folder. This change involves moving two YML files for the spaceflights starter from 'parameters' folder and adding 'parameters_' to the beginning of the filenames.

How has this been tested?

The modifications have been tested with the 'pipeline create' and 'pipeline delete' commands that were altered in #2856, as well as with the 'catalog create' command that was modified in #2884.

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

@DimedS DimedS self-assigned this Aug 3, 2023
@DimedS DimedS linked an issue Aug 3, 2023 that may be closed by this pull request
@DimedS DimedS changed the title remove nesting in parameters folder for spaceflight's YML files Update starters to use new /conf structure Aug 3, 2023
@DimedS DimedS marked this pull request as ready for review August 3, 2023 13:49
@DimedS DimedS requested a review from deepyaman August 3, 2023 13:50
Copy link
Member

@merelcht merelcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me! 👍

@DimedS DimedS requested a review from amandakys August 3, 2023 15:47
Copy link
Member

@deepyaman deepyaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DimedS DimedS merged commit 2f1dd0f into main Aug 7, 2023
@DimedS DimedS deleted the fix/update-starters-to-use-new-conf-structure branch August 7, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update starters to use new /conf structure
3 participants