Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis Lists - Connection Parameters #962

Merged
merged 4 commits into from
Aug 1, 2020

Conversation

tbickford
Copy link
Contributor

@tbickford tbickford commented Aug 1, 2020

Adding the ability to specify the address or host and port attributes as values in a secret via the TriggerAuthentication resource for the Redis Lists scaler. This avoids having to specify them as env vars in the deployment itself. I have added additional e2e tests for the uses of these parameters.

Added documentation updates in kedacore/keda-docs#216

Signed-off-by: Travis Bickford <[email protected]>
Signed-off-by: Travis Bickford <[email protected]>
Signed-off-by: Travis Bickford <[email protected]>
@tbickford tbickford changed the title Redis Lists - Authentication Parameters Redis Lists - Connection Parameters Aug 1, 2020
@ahmelsayed ahmelsayed merged commit 08c3600 into kedacore:master Aug 1, 2020
@tomkerkhove
Copy link
Member

Somewhat relates to #753 & #712

@tomkerkhove tomkerkhove added this to the v2.0 milestone Aug 3, 2020
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants