Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] generate CRD shortnames #793

Merged
merged 1 commit into from
Apr 29, 2020
Merged

[v2] generate CRD shortnames #793

merged 1 commit into from
Apr 29, 2020

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik [email protected]

Generate CRD shortnames so they can be used with kubectl get

scaledObject - so
scaledJob - sj
triggerAuthentication - ta, triggerauth

Fixes #774

Signed-off-by: Zbynek Roubalik <[email protected]>
@@ -3,11 +3,26 @@ kind: CustomResourceDefinition
metadata:
name: scaledjobs.keda.sh
spec:
additionalPrinterColumns:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to close #777 as well then or at least relate to it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add more details in the following PR to fully cover #777

@zroubalik zroubalik merged commit ccd01cf into kedacore:v2 Apr 29, 2020
@zroubalik zroubalik deleted the shortnames branch August 11, 2020 11:32
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants