[v2] KEDA client-go #787
Merged
[v2] KEDA client-go #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 28, 2020 16:09
Signed-off-by: Zbynek Roubalik <[email protected]>
Signed-off-by: Zbynek Roubalik <[email protected]>
Closed
ahmelsayed
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding generated client-go, so other projects could manage ScaledObjects and other KEDA resources from their applications, in case they prefer using client-go.
Internally in KEDA we should stick to controller-runtime client which is used currently.
Once there are any changes in api objects, it is needed to run
make generate-clientsetto regenerate clientset (I haven't add this step to the regularmake build, because the generation is quite slow and could take a lot of time). In the PR validation there's a check whether generated client is up to date. So it is not possible to merge PR with outdated clientsetFixes #494