-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ: provide separate paremeters for user and password #6180
Open
dovics
wants to merge
3
commits into
kedacore:main
Choose a base branch
from
dovics:feat-rabbitmq-auth
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovics
changed the title
feat: provide separate paremeters for user and password
RabbitMQ: provide separate paremeters for user and password
Sep 22, 2024
tests/scalers/rabbitmq/rabbitmq_queue_http_auth/rabbitmq_queue_http_auth_test.go
Show resolved
Hide resolved
tests/scalers/rabbitmq/rabbitmq_queue_amqp_auth/rabbitmq_queue_amqp_auth_test.go
Show resolved
Hide resolved
Signed-off-by: wangrushen <[email protected]>
dovics
force-pushed
the
feat-rabbitmq-auth
branch
from
September 22, 2024 03:30
f6753dc
to
3d8924f
Compare
Signed-off-by: wangrushen <[email protected]>
1 task
JorTurFer
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the improvement :)
@kedacore/keda-core-contributors PTAL |
/run-e2e rabbit |
Signed-off-by: Zbynek Roubalik <[email protected]>
zroubalik
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a description of what has been changed
rabbitmq using separate username and password, supports obtaining from environment variables or obtaining from TriggerAuthentication, and remains compatible with previous usage.
Checklist
Fixes #2513
Relates to kedacore/keda-docs#1472