-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add connection name for the rabbitmq scaler #6093
Add connection name for the rabbitmq scaler #6093
Conversation
Signed-off-by: robpickerill <[email protected]>
fbc14a8
to
ee82c26
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could you update the changelog to include this as improvement
?
Signed-off-by: Rob Pickerill <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]>
f410b8f
to
853bdfe
Compare
Done, thanks! |
853bdfe
to
8cad45f
Compare
Signed-off-by: robpickerill <[email protected]>
8cad45f
to
688e522
Compare
/run-e2e amqp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️ Thanks for the improvement!
Signed-off-by: robpickerill <[email protected]>
ac123f8
to
f5817f4
Compare
Signed-off-by: Rob Pickerill <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! ❤️
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
/run-e2e amqp |
Great, thank you! Looking forward to when this is part of a release. |
* add a static connection name Signed-off-by: robpickerill <[email protected]> * Update pkg/scalers/rabbitmq_scaler.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * add improvement to changelog Signed-off-by: robpickerill <[email protected]> * add namepace and so name to conn name Signed-off-by: robpickerill <[email protected]> * Update comment Signed-off-by: Jorge Turrado Ferrero <[email protected]> --------- Signed-off-by: robpickerill <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Fira Curie <[email protected]>
* add a static connection name Signed-off-by: robpickerill <[email protected]> * Update pkg/scalers/rabbitmq_scaler.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * add improvement to changelog Signed-off-by: robpickerill <[email protected]> * add namepace and so name to conn name Signed-off-by: robpickerill <[email protected]> * Update comment Signed-off-by: Jorge Turrado Ferrero <[email protected]> --------- Signed-off-by: robpickerill <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Jorge Turrado <[email protected]>
* add a static connection name Signed-off-by: robpickerill <[email protected]> * Update pkg/scalers/rabbitmq_scaler.go Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> * add improvement to changelog Signed-off-by: robpickerill <[email protected]> * add namepace and so name to conn name Signed-off-by: robpickerill <[email protected]> * Update comment Signed-off-by: Jorge Turrado Ferrero <[email protected]> --------- Signed-off-by: robpickerill <[email protected]> Signed-off-by: Rob Pickerill <[email protected]> Signed-off-by: Jorge Turrado Ferrero <[email protected]> Co-authored-by: Jorge Turrado Ferrero <[email protected]> Signed-off-by: michael pechner <[email protected]>
Adds connection name for the rabbitmq scaler.
Checklist
Fixes #5958