Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection name for the rabbitmq scaler #6093

Merged
merged 7 commits into from
Aug 21, 2024

Conversation

robpickerill
Copy link
Contributor

@robpickerill robpickerill commented Aug 20, 2024

Adds connection name for the rabbitmq scaler.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5958

@robpickerill robpickerill requested a review from a team as a code owner August 20, 2024 17:21
Signed-off-by: robpickerill <[email protected]>
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the changelog to include this as improvement?

pkg/scalers/rabbitmq_scaler.go Outdated Show resolved Hide resolved
robpickerill and others added 2 commits August 20, 2024 19:30
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
@robpickerill robpickerill force-pushed the rabbit-mq-connection-name branch 2 times, most recently from f410b8f to 853bdfe Compare August 20, 2024 18:36
@robpickerill
Copy link
Contributor Author

LGTM! Could you update the changelog to include this as improvement?

Done, thanks!

@robpickerill robpickerill force-pushed the rabbit-mq-connection-name branch from 853bdfe to 8cad45f Compare August 20, 2024 18:41
Signed-off-by: robpickerill <[email protected]>
@robpickerill robpickerill force-pushed the rabbit-mq-connection-name branch from 8cad45f to 688e522 Compare August 20, 2024 18:48
@JorTurFer
Copy link
Member

JorTurFer commented Aug 20, 2024

/run-e2e amqp
Update: You can check the progress here

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️ Thanks for the improvement!

@JorTurFer JorTurFer enabled auto-merge (squash) August 20, 2024 18:57
@JorTurFer JorTurFer disabled auto-merge August 20, 2024 20:22
pkg/scalers/rabbitmq_scaler.go Outdated Show resolved Hide resolved
@robpickerill robpickerill force-pushed the rabbit-mq-connection-name branch from ac123f8 to f5817f4 Compare August 21, 2024 10:52
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ❤️

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
@JorTurFer
Copy link
Member

JorTurFer commented Aug 21, 2024

/run-e2e amqp
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) August 21, 2024 11:14
@JorTurFer JorTurFer merged commit f4261e3 into kedacore:main Aug 21, 2024
18 checks passed
@mauvilsa
Copy link

Great, thank you! Looking forward to when this is part of a release.

@robpickerill robpickerill deleted the rabbit-mq-connection-name branch August 21, 2024 19:42
fira42073 pushed a commit to fira42073/keda that referenced this pull request Aug 25, 2024
* add a static connection name

Signed-off-by: robpickerill <[email protected]>

* Update pkg/scalers/rabbitmq_scaler.go

Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>

* add improvement to changelog

Signed-off-by: robpickerill <[email protected]>

* add namepace and so name to conn name

Signed-off-by: robpickerill <[email protected]>

* Update comment

Signed-off-by: Jorge Turrado Ferrero <[email protected]>

---------

Signed-off-by: robpickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Fira Curie <[email protected]>
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
* add a static connection name

Signed-off-by: robpickerill <[email protected]>

* Update pkg/scalers/rabbitmq_scaler.go

Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>

* add improvement to changelog

Signed-off-by: robpickerill <[email protected]>

* add namepace and so name to conn name

Signed-off-by: robpickerill <[email protected]>

* Update comment

Signed-off-by: Jorge Turrado Ferrero <[email protected]>

---------

Signed-off-by: robpickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
mpechner-akasa pushed a commit to nrichardson-akasa/keda that referenced this pull request Nov 29, 2024
* add a static connection name

Signed-off-by: robpickerill <[email protected]>

* Update pkg/scalers/rabbitmq_scaler.go

Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>

* add improvement to changelog

Signed-off-by: robpickerill <[email protected]>

* add namepace and so name to conn name

Signed-off-by: robpickerill <[email protected]>

* Update comment

Signed-off-by: Jorge Turrado Ferrero <[email protected]>

---------

Signed-off-by: robpickerill <[email protected]>
Signed-off-by: Rob Pickerill <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: michael pechner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Naming the keda connections in Rabbitmq
3 participants