Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulsar: remove deprecated trigger name #6092

Merged
merged 3 commits into from
Sep 4, 2024
Merged

Conversation

kunwooy
Copy link
Contributor

@kunwooy kunwooy commented Aug 20, 2024

This commit removes the deprecated trigger name msgBacklog in Pulsar scaler. msgBacklogThreshold should be used instead.

Checklist

Fixes #6059
(The original issue was intended to introduce a scaler to non-persistent Pulsar topics. But after some research, I found out that the proposed metric is infeasible)

Relates to #

@kunwooy kunwooy requested a review from a team as a code owner August 20, 2024 12:19
@kunwooy kunwooy force-pushed the main branch 2 times, most recently from 5f4a7a1 to d095a3c Compare August 22, 2024 03:31
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

Could you sign the branch please?

To add your Signed-off-by line to every commit in this branch:
1.Ensure you have a local copy of your branch by checking out the pull request locally via command line.
2. In your local branch, run: git rebase HEAD~2 --signoff
3. Force push your changes to overwrite the branch: git push --force-with-lease origin main

@kunwooy
Copy link
Contributor Author

kunwooy commented Aug 29, 2024

@JorTurFer Done!

@JorTurFer
Copy link
Member

There are failing some tests:
image
and there is also an static check failing:
image

Could you take a look please? 🙏

kunwooy and others added 2 commits September 3, 2024 20:59
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Kun Woo Yoo <[email protected]>
@kunwooy
Copy link
Contributor Author

kunwooy commented Sep 4, 2024

@JorTurFer Done! (for real this time)

@JorTurFer
Copy link
Member

JorTurFer commented Sep 4, 2024

/run-e2e pulsar
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) September 4, 2024 12:57
@JorTurFer JorTurFer merged commit 9e51a78 into kedacore:main Sep 4, 2024
19 checks passed
JorTurFer added a commit to JorTurFer/keda that referenced this pull request Oct 7, 2024
* remove deprecated trigger name in Pulsar scaler

Signed-off-by: Kun Woo Yoo <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Kun Woo Yoo <[email protected]>

* remove deprecated Pulsar trigger name from test

Signed-off-by: Kun Woo Yoo <[email protected]>

---------

Signed-off-by: Kun Woo Yoo <[email protected]>
Signed-off-by: Jorge Turrado Ferrero <[email protected]>
Co-authored-by: Jorge Turrado Ferrero <[email protected]>
Signed-off-by: Jorge Turrado <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pulsar scaler for non-persistent topics?
2 participants